Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java

Issue 2878543003: Hook up Reader Mode InfoBar (Closed)
Patch Set: add new read-time metric and clean up some state Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java
index ef50dc74f30180ea38d63a543bcd73d3e6f7ab6d..c20b00cffb98c899b5e68524df42ae84528aad63 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java
@@ -30,6 +30,12 @@ public class ReaderModeTabInfo {
// Used to flag the the panel was shown and recorded by UMA.
private boolean mShowPanelRecorded;
+ // The time that the user started viewing Reader Mode content.
+ private long mViewStartTimeMs;
+
+ // Whether or not the current tab is a Reader Mode page.
+ private boolean mIsViewingReaderModePage;
+
/**
* @param observer The WebContentsObserver for the tab this object represents.
*/
@@ -45,6 +51,31 @@ public class ReaderModeTabInfo {
}
/**
+ * A notification that the user started viewing Reader Mode.
+ */
+ public void onStartedReaderMode() {
+ mIsViewingReaderModePage = true;
+ mViewStartTimeMs = System.currentTimeMillis();
wychen 2017/05/17 07:24:12 Monotonic time like elapsedRealtime() should be be
mdjones 2017/05/17 16:52:14 Done.
+ }
+
+ /**
+ * A notification that the user is no longer viewing Reader Mode. This could be because of a
+ * navigation away from the page, switching tabs, or closing the browser.
+ * @return The amount of time in ms that the user spent viewing Reader Mode.
+ */
+ public long onExitReaderMode() {
+ mIsViewingReaderModePage = false;
+ return System.currentTimeMillis() - mViewStartTimeMs;
+ }
+
+ /**
+ * @return Whether or not the user is on a Reader Mode page.
+ */
+ public boolean isViewingReaderModePage() {
+ return mIsViewingReaderModePage;
+ }
+
+ /**
* @param status The status of reader mode for this object's tab.
*/
public void setStatus(int status) {

Powered by Google App Engine
This is Rietveld 408576698