Implements CSSPropertyAPI for the offset-path property

Implements CSSPropertyAPI for the offset-path property

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPath from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API
for the offset-path property is stored in a CSSPropertyDescriptor,
and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPath.cpp to the BUILD.gn file.
- Adds parseSingleValue to "offset-path" in CSSProperties.json5
  so that it will be added to the generated files for the api.
- Moves the parsing logic for offset-path from CSSPropertyParser.cpp
  to CSSPropertyAPIOffsetPath.cpp, which implements
  CSSPropertyAPI.h.


BUG=668012
Review-Url: https://codereview.chromium.org/2878533004
Cr-Commit-Position: refs/heads/master@{#471289}
Committed: https://chromium.googlesource.com/chromium/src/+/545f7be4401875ef9842de21144da3561281b2db

[Eric Willigers, 2017-05-11 05:22:31]

ericwilligers@chromium.org changed reviewers:
+ bugsnash@chromium.org

[Eric Willigers, 2017-05-11 05:22:31]

Diffs in generated files:
https://gist.github.com/ewilligers/02f396260667f41fda900330197a8068/revisions

[Bugs Nash, 2017-05-11 23:19:06]

lgtm with changes. As with previous patch, please add the new .h file to
core/BUILD.gn

https://codereview.chromium.org/2878533004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp
(right):

https://codereview.chromium.org/2878533004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp:8: 
As with previous patch, please forward declare CSSValue, CSSParserTokenRange,
CSSParserContext, and CSSPropertyID

[Eric Willigers, 2017-05-12 00:26:47]

On 2017/05/11 23:19:06, Bugs Nash wrote:
> ... As with previous patch, please add the new .h file to
> core/BUILD.gn

Done

[Eric Willigers, 2017-05-12 00:29:38]

ericwilligers@chromium.org changed reviewers:
+ meade@chromium.org

[Eric Willigers, 2017-05-12 00:29:38]

https://codereview.chromium.org/2878533004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp
(right):

https://codereview.chromium.org/2878533004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp:8: 
On 2017/05/11 23:19:06, Bugs Nash wrote:
> As with previous patch, please forward declare CSSValue, CSSParserTokenRange,
> CSSParserContext, and CSSPropertyID

Not needed, these types are used in a method signature appearing in this file's
header.

[meade_UTC10, 2017-05-12 04:21:05]

rs lgtm

[Eric Willigers, 2017-05-12 04:34:50]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 04:35:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:47:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:47:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2017-05-12 08:29:07]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-05-12 08:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2878533004/#ps20001
(title: "add the new generated .h file to core/BUILD.gn")

[commit-bot: I haz the power, 2017-05-12 08:29:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 09:44:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 09:44:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2017-05-12 12:25:15]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-05-12 12:25:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 12:52:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494591915470470,
"parent_rev": "810daba795ae080b446ab7ef573ed2386028f940", "commit_rev":
"545f7be4401875ef9842de21144da3561281b2db"}

[commit-bot: I haz the power, 2017-05-12 12:52:23]

Description was changed from

==========
Implements CSSPropertyAPI for the offset-path property

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPath from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API
for the offset-path property is stored in a CSSPropertyDescriptor,
and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPath.cpp to the BUILD.gn file.
- Adds parseSingleValue to "offset-path" in CSSProperties.json5
  so that it will be added to the generated files for the api.
- Moves the parsing logic for offset-path from CSSPropertyParser.cpp
  to CSSPropertyAPIOffsetPath.cpp, which implements
  CSSPropertyAPI.h.


BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the offset-path property

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPath from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API
for the offset-path property is stored in a CSSPropertyDescriptor,
and is called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPath.cpp to the BUILD.gn file.
- Adds parseSingleValue to "offset-path" in CSSProperties.json5
  so that it will be added to the generated files for the api.
- Moves the parsing logic for offset-path from CSSPropertyParser.cpp
  to CSSPropertyAPIOffsetPath.cpp, which implements
  CSSPropertyAPI.h.


BUG=668012

Review-Url: https://codereview.chromium.org/2878533004
Cr-Commit-Position: refs/heads/master@{#471289}
Committed:
https://chromium.googlesource.com/chromium/src/+/545f7be4401875ef9842de21144d...
==========

[commit-bot: I haz the power, 2017-05-12 12:52:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/545f7be4401875ef9842de21144d...