Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2878533003: tracing: the client lib of the tracing service (Closed)

Created:
3 years, 7 months ago by chiniforooshan
Modified:
3 years, 7 months ago
CC:
chrome-grc-reviews_chromium.org, chromium-reviews, tracing-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing: The client lib of the tracing service Any process that needs to connect to the tracing service and provide trace events can just call TraceEventAgent::GetOrCreateInstance and pass a connection to an implementation of the AgentSet interface. A somewhat working prototype that includes the service implementation: https://codereview.chromium.org/2833873003/ Design doc (use @chromium.org account): https://docs.google.com/document/d/1osLqctK_rTiioKFOG9wDLkrCQ9DLJZmm4j-S335u-vM BUG=640235 Review-Url: https://codereview.chromium.org/2878533003 Cr-Commit-Position: refs/heads/master@{#472989} Committed: https://chromium.googlesource.com/chromium/src/+/b3cad27b421b2aa9f6b0a89c80238480ba14023e

Patch Set 1 #

Patch Set 2 : metadata generator #

Patch Set 3 : . #

Total comments: 21

Patch Set 4 : review #

Total comments: 14

Patch Set 5 : review #

Total comments: 8

Patch Set 6 : review #

Total comments: 6

Patch Set 7 : review #

Patch Set 8 : review #

Patch Set 9 : fix a missing dep #

Patch Set 10 : use thread checker macros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -9 lines) Patch
M services/resource_coordinator/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M services/resource_coordinator/public/cpp/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A services/resource_coordinator/public/cpp/tracing/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.h View 1 2 3 4 5 6 7 1 chunk +65 lines, -0 lines 0 comments Download
A services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc View 1 2 3 4 5 6 7 8 9 1 chunk +113 lines, -0 lines 0 comments Download
A services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent_unittest.cc View 1 2 3 4 5 1 chunk +179 lines, -0 lines 0 comments Download
M services/resource_coordinator/public/interfaces/tracing/tracing.mojom View 1 2 3 4 5 6 3 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 32 (12 generated)
chiniforooshan
ptal.
3 years, 7 months ago (2017-05-11 06:55:36 UTC) #3
Primiano Tucci (use gerrit)
Thanks, after you warmed me up with the memory_instrumentation servicification no I feel I understand ...
3 years, 7 months ago (2017-05-11 15:31:07 UTC) #4
chiniforooshan
Thank you for reviewing this! https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc File services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc (right): https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc#newcode19 services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc:19: TraceEventAgent* TraceEventAgent::GetOrCreateInstance( On 2017/05/11 ...
3 years, 7 months ago (2017-05-15 20:44:12 UTC) #5
Primiano Tucci (use gerrit)
sorry for the delay. I meant to send this reply this morning, but then I ...
3 years, 7 months ago (2017-05-16 04:45:12 UTC) #6
chiniforooshan
https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc File services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc (right): https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc#newcode19 services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc:19: TraceEventAgent* TraceEventAgent::GetOrCreateInstance( On 2017/05/16 04:45:11, Primiano (slow - traveling) ...
3 years, 7 months ago (2017-05-16 15:14:45 UTC) #7
chiniforooshan
Pinging Oystein :)
3 years, 7 months ago (2017-05-16 19:28:06 UTC) #8
chiniforooshan
+Ken for tracing.mojom
3 years, 7 months ago (2017-05-16 19:29:52 UTC) #10
oystein (OOO til 10th of July)
https://codereview.chromium.org/2878533003/diff/80001/services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc File services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc (right): https://codereview.chromium.org/2878533003/diff/80001/services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc#newcode50 services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc:50: metadata_generator_functions_.push_back(generator); Would a DCHECK(recorder_); make sense here? https://codereview.chromium.org/2878533003/diff/80001/services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc#newcode70 services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent.cc:70: ...
3 years, 7 months ago (2017-05-16 21:19:06 UTC) #11
Primiano Tucci (use gerrit)
https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc File services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc (right): https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc#newcode19 services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc:19: TraceEventAgent* TraceEventAgent::GetOrCreateInstance( On 2017/05/16 15:14:44, chiniforooshan wrote: > On ...
3 years, 7 months ago (2017-05-17 00:28:17 UTC) #12
chiniforooshan
https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc File services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc (right): https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc#newcode19 services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc:19: TraceEventAgent* TraceEventAgent::GetOrCreateInstance( On 2017/05/17 00:28:17, Primiano (slow - traveling) ...
3 years, 7 months ago (2017-05-17 06:33:47 UTC) #13
kenrb
mojom lgtm, with a nit and a question. https://codereview.chromium.org/2878533003/diff/100001/services/resource_coordinator/public/interfaces/tracing/tracing.mojom File services/resource_coordinator/public/interfaces/tracing/tracing.mojom (right): https://codereview.chromium.org/2878533003/diff/100001/services/resource_coordinator/public/interfaces/tracing/tracing.mojom#newcode25 services/resource_coordinator/public/interfaces/tracing/tracing.mojom:25: // ...
3 years, 7 months ago (2017-05-17 21:24:02 UTC) #14
chiniforooshan
https://codereview.chromium.org/2878533003/diff/100001/services/resource_coordinator/public/interfaces/tracing/tracing.mojom File services/resource_coordinator/public/interfaces/tracing/tracing.mojom (right): https://codereview.chromium.org/2878533003/diff/100001/services/resource_coordinator/public/interfaces/tracing/tracing.mojom#newcode25 services/resource_coordinator/public/interfaces/tracing/tracing.mojom:25: // reasones: although we want to let almost every ...
3 years, 7 months ago (2017-05-17 21:33:18 UTC) #15
oystein (OOO til 10th of July)
lgtm and thanks! On 2017/05/17 at 06:33:47, chiniforooshan wrote: > https://codereview.chromium.org/2878533003/diff/40001/services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc > File services/resource_coordinator/public/cpp/tracing/trace_event_agent.cc (right): ...
3 years, 7 months ago (2017-05-17 21:49:00 UTC) #16
kenrb
Still lgtm. https://codereview.chromium.org/2878533003/diff/100001/services/resource_coordinator/public/interfaces/tracing/tracing.mojom File services/resource_coordinator/public/interfaces/tracing/tracing.mojom (right): https://codereview.chromium.org/2878533003/diff/100001/services/resource_coordinator/public/interfaces/tracing/tracing.mojom#newcode60 services/resource_coordinator/public/interfaces/tracing/tracing.mojom:60: interface Coordinator { On 2017/05/17 21:33:17, chiniforooshan ...
3 years, 7 months ago (2017-05-18 02:19:52 UTC) #17
chiniforooshan
Thanks everyone! > That's fair, though it would be great if we could come up ...
3 years, 7 months ago (2017-05-18 15:23:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878533003/140001
3 years, 7 months ago (2017-05-18 15:26:05 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458935)
3 years, 7 months ago (2017-05-18 15:30:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878533003/160001
3 years, 7 months ago (2017-05-18 16:12:16 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878533003/180001
3 years, 7 months ago (2017-05-18 18:17:20 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 00:20:53 UTC) #32
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/b3cad27b421b2aa9f6b0a89c8023...

Powered by Google App Engine
This is Rietveld 408576698