Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2878533002: SimpleCache: Tolerate weird file sizes when doing index recovery. (Closed)

Created:
3 years, 7 months ago by Maks Orlovich
Modified:
3 years, 7 months ago
Reviewers:
pasko, Mark P
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

SimpleCache: Tolerate weird file sizes when doing index recovery. (Rather than __builtin_trap-crashing) BUG=712326 Review-Url: https://codereview.chromium.org/2878533002 Cr-Commit-Position: refs/heads/master@{#474055} Committed: https://chromium.googlesource.com/chromium/src/+/2ea7908fea095d9644122e8391ed2fb87fd2e621

Patch Set 1 #

Total comments: 7

Patch Set 2 : Rework comment, add check on size in open + UMA enum for that failure #

Patch Set 3 : Woops, the test was meant to be a different CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M net/disk_cache/simple/simple_index_file.cc View 1 1 chunk +38 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 43 (22 generated)
Maks Orlovich
3 years, 7 months ago (2017-05-10 19:27:27 UTC) #4
Maks Orlovich
ChromeOS build failure is: ../../ui/views/view.h:22:10: fatal error: 'ui/accessibility/ax_enums.h' file not found #include "ui/accessibility/ax_enums.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...
3 years, 7 months ago (2017-05-10 19:58:21 UTC) #8
pasko
this only happens when stat(2) returned garbage in st_size during index scan, right? I guess ...
3 years, 7 months ago (2017-05-11 12:15:07 UTC) #9
Maks Orlovich
On 2017/05/11 12:15:07, pasko wrote: > this only happens when stat(2) returned garbage in st_size ...
3 years, 7 months ago (2017-05-11 13:35:13 UTC) #10
pasko
On 2017/05/11 13:35:13, Maks Orlovich wrote: > On 2017/05/11 12:15:07, pasko wrote: > > I ...
3 years, 7 months ago (2017-05-11 15:17:59 UTC) #15
Maks Orlovich
> Do you still prefer the current late-and-placeholder approach? I'd probably > l-g-t-m it, since ...
3 years, 7 months ago (2017-05-18 19:52:26 UTC) #16
pasko
On 2017/05/18 19:52:26, Maks Orlovich wrote: > > Do you still prefer the current late-and-placeholder ...
3 years, 7 months ago (2017-05-19 09:32:19 UTC) #17
morlovich
https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc File net/disk_cache/simple/simple_index_file.cc (right): https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc#newcode166 net/disk_cache/simple/simple_index_file.cc:166: // get removed. So we just make something up; ...
3 years, 7 months ago (2017-05-19 11:35:06 UTC) #18
Maks Orlovich
https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc File net/disk_cache/simple/simple_index_file.cc (right): https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc#newcode169 net/disk_cache/simple/simple_index_file.cc:169: const int kPlaceHolderSizeWhenInvalid = 32768; On 2017/05/19 11:35:05, morlovich ...
3 years, 7 months ago (2017-05-19 13:18:06 UTC) #19
pasko
https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc File net/disk_cache/simple/simple_index_file.cc (right): https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc#newcode169 net/disk_cache/simple/simple_index_file.cc:169: const int kPlaceHolderSizeWhenInvalid = 32768; On 2017/05/19 13:18:06, Maks ...
3 years, 7 months ago (2017-05-19 14:38:07 UTC) #20
Maks Orlovich
https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc File net/disk_cache/simple/simple_index_file.cc (right): https://codereview.chromium.org/2878533002/diff/1/net/disk_cache/simple/simple_index_file.cc#newcode169 net/disk_cache/simple/simple_index_file.cc:169: const int kPlaceHolderSizeWhenInvalid = 32768; > ah, you are ...
3 years, 7 months ago (2017-05-19 15:09:58 UTC) #21
Maks Orlovich
PTAL
3 years, 7 months ago (2017-05-19 16:34:56 UTC) #24
pasko
lgtm, thank you for extensive investigation and a helpful comment sorry for review latency, I ...
3 years, 7 months ago (2017-05-23 12:12:01 UTC) #31
Maks Orlovich
+mpearson for enums.xml addition
3 years, 7 months ago (2017-05-23 13:22:11 UTC) #33
Mark P
enums.xml lgtm, assuming that this isn't coming from a different bucket (i.e., it's something new ...
3 years, 7 months ago (2017-05-23 19:19:50 UTC) #34
Maks Orlovich
On 2017/05/23 19:19:50, Mark P wrote: > enums.xml lgtm, assuming that this isn't coming from ...
3 years, 7 months ago (2017-05-23 19:37:49 UTC) #35
Mark P
On Tue, May 23, 2017 at 12:37 PM, <morlovich@chromium.org> wrote: > On 2017/05/23 19:19:50, Mark ...
3 years, 7 months ago (2017-05-23 19:40:37 UTC) #36
Maks Orlovich
On 2017/05/23 19:40:37, Mark P wrote: > On Tue, May 23, 2017 at 12:37 PM, ...
3 years, 7 months ago (2017-05-23 19:44:22 UTC) #37
Mark P
On Tue, May 23, 2017 at 12:44 PM, <morlovich@chromium.org> wrote: > On 2017/05/23 19:40:37, Mark ...
3 years, 7 months ago (2017-05-23 19:47:06 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878533002/40001
3 years, 7 months ago (2017-05-23 19:48:17 UTC) #40
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 21:15:56 UTC) #43
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2ea7908fea095d9644122e8391ed...

Powered by Google App Engine
This is Rietveld 408576698