|
|
Descriptionbuild: Use ICF more often now that our binutils is patched.
BUG=576197
R=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2878513002
Cr-Commit-Position: refs/heads/master@{#471147}
Committed: https://chromium.googlesource.com/chromium/src/+/df9197b54026160887760b92a9500111a2b121b3
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by pcc@chromium.org
The CQ bit was checked by pcc@chromium.org to run a CQ dry run
lgtm, fingers crossed. https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (left): https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:404: ldflags += [ "-Wl,--icf=none" ] This is the default everywhere, yes?
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (left): https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:404: ldflags += [ "-Wl,--icf=none" ] Yes as best as I can tell from reading the gold and lld sources.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by pcc@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pcc@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494541853469350, "parent_rev": "356b56ebd085219c574858880d8ef0d15226bfda", "commit_rev": "df9197b54026160887760b92a9500111a2b121b3"}
Message was sent while issue was closed.
Description was changed from ========== build: Use ICF more often now that our binutils is patched. BUG=576197 R=thakis@chromium.org ========== to ========== build: Use ICF more often now that our binutils is patched. BUG=576197 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2878513002 Cr-Commit-Position: refs/heads/master@{#471147} Committed: https://chromium.googlesource.com/chromium/src/+/df9197b54026160887760b92a950... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/df9197b54026160887760b92a950... |