Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2878513002: build: Use ICF more often now that our binutils is patched. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Use ICF more often now that our binutils is patched. BUG=576197 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2878513002 Cr-Commit-Position: refs/heads/master@{#471147} Committed: https://chromium.googlesource.com/chromium/src/+/df9197b54026160887760b92a9500111a2b121b3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -13 lines 2 comments Download

Messages

Total messages: 17 (10 generated)
pcc1
3 years, 7 months ago (2017-05-10 18:11:11 UTC) #1
Nico
lgtm, fingers crossed. https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (left): https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD.gn#oldcode404 build/config/compiler/BUILD.gn:404: ldflags += [ "-Wl,--icf=none" ] This ...
3 years, 7 months ago (2017-05-10 18:13:16 UTC) #4
pcc1
https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (left): https://codereview.chromium.org/2878513002/diff/1/build/config/compiler/BUILD.gn#oldcode404 build/config/compiler/BUILD.gn:404: ldflags += [ "-Wl,--icf=none" ] Yes as best as ...
3 years, 7 months ago (2017-05-10 18:17:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878513002/1
3 years, 7 months ago (2017-05-11 19:36:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/368562)
3 years, 7 months ago (2017-05-11 21:46:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878513002/1
3 years, 7 months ago (2017-05-11 22:31:56 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 00:36:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df9197b54026160887760b92a950...

Powered by Google App Engine
This is Rietveld 408576698