Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2878503003: Convert accessibility_helper.mojom to snake casing (Closed)

Created:
3 years, 7 months ago by David Tseng
Modified:
3 years, 7 months ago
Reviewers:
dcheng, yawano
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, dtseng+watch_chromium.org, yzshen+watch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, aboxhall+watch_chromium.org, hidehiko+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, abarth-chromium, Aaron Boodman, dougt+watch_chromium.org, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, victorhsieh+watch_chromium.org, je_julie, darin (slow to review), davemoore+watch_chromium.org, qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert accessibility_helper.mojom to snake casing CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2878503003 Cr-Commit-Position: refs/heads/master@{#471556} Committed: https://chromium.googlesource.com/chromium/src/+/4c1b94d4d7d0dc79e8cf787c50317428dae76eb7

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -52 lines) Patch
M chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc View 1 3 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc View 7 chunks +25 lines, -25 lines 0 comments Download
M components/arc/common/accessibility_helper.mojom View 3 chunks +13 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (17 generated)
David Tseng
Thanks for catching this; I think the mojom file was first written from someone developing ...
3 years, 7 months ago (2017-05-10 21:49:10 UTC) #3
dcheng
mojo lgtm
3 years, 7 months ago (2017-05-10 21:58:57 UTC) #4
David Tseng
+ yawano
3 years, 7 months ago (2017-05-11 03:13:01 UTC) #6
yawano
c/b/chromeos/arc/accessibility lgtm. Thank you for fixing this!
3 years, 7 months ago (2017-05-11 03:26:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878503003/40001
3 years, 7 months ago (2017-05-13 04:01:10 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4c1b94d4d7d0dc79e8cf787c50317428dae76eb7
3 years, 7 months ago (2017-05-13 04:06:42 UTC) #23
Luis Héctor Chávez
3 years, 7 months ago (2017-05-15 19:50:15 UTC) #24
Message was sent while issue was closed.
On 2017/05/10 21:49:10, David Tseng wrote:
> Thanks for catching this; I think the mojom file was first written from
someone
> developing on Android and I don't think we ever looked at the other mojom
files
> to get the proper mojo format. Verified that the same mojom file compiles
> without code changes on Android, so I believe no versioning is needed as you
> pointed out.

FYI the names of the structs / methods / parameters are never sent through the
wire (as in with protobufs), so it's always safe to rename them.

Powered by Google App Engine
This is Rietveld 408576698