Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
Review-Url: https://codereview.chromium.org/2878483003
Cr-Commit-Position: refs/heads/master@{#470753}
Committed: https://chromium.googlesource.com/chromium/src/+/c741e88553c0e49469bf7b8ef18bde571dc1740c
Description was changed from ========== Polymer/Closure: fix bug in script that generates Closure GYP Previously, ...
3 years, 7 months ago
(2017-05-10 22:35:19 UTC)
#1
Description was changed from
==========
Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
==========
to
==========
Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
3 years, 7 months ago
(2017-05-10 22:42:55 UTC)
#3
lgtm
Dan Beam
Description was changed from ========== Polymer/Closure: fix bug in script that generates Closure GYP Previously, ...
3 years, 7 months ago
(2017-05-10 23:33:41 UTC)
#4
Description was changed from
==========
Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
==========
Dan Beam
The CQ bit was checked by dbeam@chromium.org
3 years, 7 months ago
(2017-05-10 23:33:44 UTC)
#5
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494459224172700, "parent_rev": "bb92571ebde21cea713ce66c5330f5907ae5cafc", "commit_rev": "c741e88553c0e49469bf7b8ef18bde571dc1740c"}
3 years, 7 months ago
(2017-05-10 23:45:45 UTC)
#7
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494459224172700, "parent_rev":
"bb92571ebde21cea713ce66c5330f5907ae5cafc", "commit_rev":
"c741e88553c0e49469bf7b8ef18bde571dc1740c"}
commit-bot: I haz the power
Description was changed from ========== Polymer/Closure: fix bug in script that generates Closure GYP Previously, ...
3 years, 7 months ago
(2017-05-10 23:45:55 UTC)
#8
Message was sent while issue was closed.
Description was changed from
==========
Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
==========
to
==========
Polymer/Closure: fix bug in script that generates Closure GYP
Previously, .html files being passed to the script assumed that there
was an equivalent "crisped" -extracted.js. In attempting to get other
things working, we discovered there were a bunch of non-existent targets
being created (reading the files of each target_name was failing).
Because nobody actually used these targets, they didn't really hurt
anything but also shouldn't exist.
So I fixed the glitch.
R=dpapad@chromium.org
BUG=720011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
Review-Url: https://codereview.chromium.org/2878483003
Cr-Commit-Position: refs/heads/master@{#470753}
Committed:
https://chromium.googlesource.com/chromium/src/+/c741e88553c0e49469bf7b8ef18b...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c741e88553c0e49469bf7b8ef18bde571dc1740c
3 years, 7 months ago
(2017-05-10 23:45:56 UTC)
#9
Issue 2878483003: Polymer/Closure: fix bug in script that generates Closure GYP
(Closed)
Created 3 years, 7 months ago by Dan Beam
Modified 3 years, 7 months ago
Reviewers: dpapad
Base URL:
Comments: 1