Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2878483003: Polymer/Closure: fix bug in script that generates Closure GYP (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, dbeam+watch-closure_chromium.org, dcheng, jlklein+watch-closure_chromium.org, michaelpg+watch-polymer_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer/Closure: fix bug in script that generates Closure GYP Previously, .html files being passed to the script assumed that there was an equivalent "crisped" -extracted.js. In attempting to get other things working, we discovered there were a bunch of non-existent targets being created (reading the files of each target_name was failing). Because nobody actually used these targets, they didn't really hurt anything but also shouldn't exist. So I fixed the glitch. R=dpapad@chromium.org BUG=720011 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Review-Url: https://codereview.chromium.org/2878483003 Cr-Commit-Position: refs/heads/master@{#470753} Committed: https://chromium.googlesource.com/chromium/src/+/c741e88553c0e49469bf7b8ef18bde571dc1740c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -315 lines) Patch
D third_party/polymer/v1_0/components-chromium/font-roboto/compiled_resources2.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-flex-layout/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-icons/compiled_resources2.gyp View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-test-helpers/compiled_resources2.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp View 3 chunks +0 lines, -41 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/compiled_resources2.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/compiled_resources2.gyp View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/compiled_resources2.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-styles/classes/compiled_resources2.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/compiled_resources2.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/generate_gyp.sh View 1 chunk +11 lines, -3 lines 0 comments Download
M tools/polymer/generate_compiled_resources_gyp.py View 2 chunks +14 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (5 generated)
Dan Beam
https://codereview.chromium.org/2878483003/diff/1/tools/polymer/generate_compiled_resources_gyp.py File tools/polymer/generate_compiled_resources_gyp.py (right): https://codereview.chromium.org/2878483003/diff/1/tools/polymer/generate_compiled_resources_gyp.py#newcode45 tools/polymer/generate_compiled_resources_gyp.py:45: html_files = filter(_has_extracted_js, html_files) the fix
3 years, 7 months ago (2017-05-10 22:35:40 UTC) #2
dpapad
lgtm
3 years, 7 months ago (2017-05-10 22:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878483003/1
3 years, 7 months ago (2017-05-10 23:34:45 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 23:45:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c741e88553c0e49469bf7b8ef18b...

Powered by Google App Engine
This is Rietveld 408576698