Use ScopedTaskEnvironment instead of MessageLoop in service_manager::test::ServiceTest.

Use ScopedTaskEnvironment instead of MessageLoop in service_manager::test::ServiceTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
Review-Url: https://codereview.chromium.org/2878453002
Cr-Commit-Position: refs/heads/master@{#470758}
Committed: https://chromium.googlesource.com/chromium/src/+/39a2ba43e67ba75529e838adc853f2ad1f2ce473

[fdoray, 2017-05-10 15:50:56]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 15:51:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-10 15:55:10]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 15:55:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 16:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 16:07:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-05-10 16:19:15]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 16:20:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-10 16:53:49]

fdoray@chromium.org changed reviewers:
+ jam@chromium.org

[fdoray, 2017-05-10 16:53:50]

jam@: Please take a look.

https://codereview.chromium.org/2878453002/diff/40001/content/browser/dom_sto...
File content/browser/dom_storage/local_storage_context_mojo_unittest.cc (left):

https://codereview.chromium.org/2878453002/diff/40001/content/browser/dom_sto...
content/browser/dom_storage/local_storage_context_mojo_unittest.cc:681: return
nullptr;
Returning nullptr prevented initialization of a MessageLoop by the base class,
which was required for the TestBrowserThreadBundle member below. This is no
longer required now that TestBrowserThreadBundle can cohabit with
ScopedTaskEnvironment.
https://chromium.googlesource.com/chromium/src/+/8c5805290290f2e7749c27ee7ea0...

https://codereview.chromium.org/2878453002/diff/40001/services/preferences/pr...
File services/preferences/pref_service_factory_unittest.cc (left):

https://codereview.chromium.org/2878453002/diff/40001/services/preferences/pr...
services/preferences/pref_service_factory_unittest.cc:118:
std::unique_ptr<base::MessageLoop> CreateMessageLoop() override {
I doubt that creating the SequencedWorkerPoolOwner right after MessageLoop
matters and is worth the extra complexity.

[commit-bot: I haz the power, 2017-05-10 16:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 16:54:21]

Dry run: This issue passed the CQ dry run.

[jam, 2017-05-10 22:16:25]

lgtm

[fdoray, 2017-05-10 23:55:39]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:56:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:05:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494460539993210,
"parent_rev": "366b2246d6fcba8fd2cef00f3ef03acd53a5d47c", "commit_rev":
"39a2ba43e67ba75529e838adc853f2ad1f2ce473"}

[commit-bot: I haz the power, 2017-05-11 00:06:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494460539993210,
"parent_rev": "366b2246d6fcba8fd2cef00f3ef03acd53a5d47c", "commit_rev":
"39a2ba43e67ba75529e838adc853f2ad1f2ce473"}

[commit-bot: I haz the power, 2017-05-11 00:06:02]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in
service_manager::test::ServiceTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in
service_manager::test::ServiceTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584

Review-Url: https://codereview.chromium.org/2878453002
Cr-Commit-Position: refs/heads/master@{#470758}
Committed:
https://chromium.googlesource.com/chromium/src/+/39a2ba43e67ba75529e838adc853...
==========

[commit-bot: I haz the power, 2017-05-11 00:06:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39a2ba43e67ba75529e838adc853...