Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 2878453002: Use ScopedTaskEnvironment instead of MessageLoop in service_manager::test::ServiceTest. (Closed)

Created:
2 years ago by fdoray
Modified:
2 years ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), gab
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoop in service_manager::test::ServiceTest. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 Review-Url: https://codereview.chromium.org/2878453002 Cr-Commit-Position: refs/heads/master@{#470758} Committed: https://chromium.googlesource.com/chromium/src/+/39a2ba43e67ba75529e838adc853f2ad1f2ce473

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : fix-build-error #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -42 lines) Patch
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 chunk +0 lines, -4 lines 1 comment Download
M services/preferences/pref_service_factory_unittest.cc View 1 2 4 chunks +6 lines, -18 lines 1 comment Download
M services/service_manager/public/cpp/service_test.h View 3 chunks +3 lines, -5 lines 0 comments Download
M services/service_manager/public/cpp/service_test.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M services/ui/ws/window_manager_client_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
fdoray
jam@: Please take a look. https://codereview.chromium.org/2878453002/diff/40001/content/browser/dom_storage/local_storage_context_mojo_unittest.cc File content/browser/dom_storage/local_storage_context_mojo_unittest.cc (left): https://codereview.chromium.org/2878453002/diff/40001/content/browser/dom_storage/local_storage_context_mojo_unittest.cc#oldcode681 content/browser/dom_storage/local_storage_context_mojo_unittest.cc:681: return nullptr; Returning nullptr ...
2 years ago (2017-05-10 16:53:50 UTC) #10
jam
lgtm
2 years ago (2017-05-10 22:16:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878453002/40001
2 years ago (2017-05-10 23:56:31 UTC) #15
commit-bot: I haz the power
2 years ago (2017-05-11 00:06:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39a2ba43e67ba75529e838adc853...

Powered by Google App Engine
This is Rietveld 408576698