Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2878383002: Added null safety for CSSParserContext in CSSPropertyShapeUtils. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added null safety for CSSParserContext in CSSProperty utils files. Changed CSSParserContext argument from * to & for null safety and readability. Call sites are currently guaranteed to not pass null as they convert from const refs themselves. BUG=668012 Review-Url: https://codereview.chromium.org/2878383002 Cr-Commit-Position: refs/heads/master@{#471702} Committed: https://chromium.googlesource.com/chromium/src/+/2c1c51b6f4179133c0b5dbb03cc5d69837c5088a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShapeOutside.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp View 7 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bugs Nash
3 years, 7 months ago (2017-05-15 05:57:39 UTC) #4
shend
lgtm
3 years, 7 months ago (2017-05-15 05:58:25 UTC) #5
Bugs Nash
+suzyh for owners
3 years, 7 months ago (2017-05-15 06:56:51 UTC) #7
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-15 07:17:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878383002/1
3 years, 7 months ago (2017-05-15 08:43:26 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 08:48:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c1c51b6f4179133c0b5dbb03cc5...

Powered by Google App Engine
This is Rietveld 408576698