Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2878353003:
DevTools: JS color theme bikeshedding v2 (Closed)
|
Created:
3 years, 7 months ago by paulirish Modified:
3 years, 6 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: JS color theme bikeshedding v2
BUG=721986
Review-Url: https://codereview.chromium.org/2878353003
Cr-Commit-Position: refs/heads/master@{#474106}
Committed: https://chromium.googlesource.com/chromium/src/+/067dbc41af8c1f0858c94ebaf4baee0346b8407f
Patch Set 1 #Patch Set 2 : DevTools: JS color theme bikeshedding v2 #Patch Set 3 : rebase #Messages
Total messages: 22 (11 generated)
paulirish@chromium.org changed reviewers: + dgozman@chromium.org, einbinder@chromium.org
Joel informed me we don't use pure black, so I'm letting these two properties fall through and catch their foreground color from the cascade.
lgtm
lgtm
The CQ bit was checked by paulirish@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by paulirish@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by paulirish@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by paulirish@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from einbinder@chromium.org, dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2878353003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495575519199100,
"parent_rev": "b4aa7f298694550c0944dfe0894b1a6cfdf912a0", "commit_rev":
"067dbc41af8c1f0858c94ebaf4baee0346b8407f"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: JS color theme bikeshedding v2 BUG=721986 ========== to ========== DevTools: JS color theme bikeshedding v2 BUG=721986 Review-Url: https://codereview.chromium.org/2878353003 Cr-Commit-Position: refs/heads/master@{#474106} Committed: https://chromium.googlesource.com/chromium/src/+/067dbc41af8c1f0858c94ebaf4ba... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/067dbc41af8c1f0858c94ebaf4ba... |
