Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2878343003: [turbofan] Ignore accumulator uses in frame state for the apply-argument optimization decision. (Closed)

Created:
3 years, 7 months ago by Jarin
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ignore accumulator uses in frame state for the apply-argument optimization decision. BUG=chromium:718820 Review-Url: https://codereview.chromium.org/2878343003 Cr-Commit-Position: refs/heads/master@{#45292} Committed: https://chromium.googlesource.com/v8/v8/+/168eb163a71eca13dd8bbe5854d5589aa885e065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/compiler/js-call-reducer.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 7 months ago (2017-05-15 08:04:04 UTC) #4
Benedikt Meurer
LGTM
3 years, 7 months ago (2017-05-15 08:05:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878343003/1
3 years, 7 months ago (2017-05-15 08:10:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 08:35:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/168eb163a71eca13dd8bbe5854d5589aa88...

Powered by Google App Engine
This is Rietveld 408576698