Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2878343002:
Use LoadingTaskRunner for cancel_timer_ of Resource class (Closed)
|
Created:
3 years, 7 months ago by horo Modified:
3 years, 7 months ago Reviewers:
kinuko CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse LoadingTaskRunner for cancel_timer_ of Resource class
BUG=443374
Review-Url: https://codereview.chromium.org/2878343002
Cr-Commit-Position: refs/heads/master@{#471716}
Committed: https://chromium.googlesource.com/chromium/src/+/16ed410611fef5999f2cea2eeec4b6e2fafffc8a
Patch Set 1 #
Total comments: 2
Patch Set 2 : add comment #Messages
Total messages: 16 (9 generated)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
horo@chromium.org changed reviewers: + kinuko@chromium.org
kinuko@ Please take a look.
lgtm https://codereview.chromium.org/2878343002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/loader/fetch/Resource.cpp (right): https://codereview.chromium.org/2878343002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/loader/fetch/Resource.cpp:272: cancel_timer_(IsMainThread() ? Platform::Current() Can you add a short comment like: 'we use MainThread() for main-thread cases to avoid TLS cost to retrieve the current thread'
Thank you https://codereview.chromium.org/2878343002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/loader/fetch/Resource.cpp (right): https://codereview.chromium.org/2878343002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/loader/fetch/Resource.cpp:272: cancel_timer_(IsMainThread() ? Platform::Current() On 2017/05/15 06:24:48, kinuko wrote: > Can you add a short comment like: 'we use MainThread() for main-thread cases to > avoid TLS cost to retrieve the current thread' Done.
The CQ bit was checked by horo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org Link to the patchset: https://codereview.chromium.org/2878343002/#ps20001 (title: "add comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494839493236250,
"parent_rev": "643d574b3e9051ee8943a58590f94bc7ab51b6b8", "commit_rev":
"16ed410611fef5999f2cea2eeec4b6e2fafffc8a"}
Message was sent while issue was closed.
Description was changed from ========== Use LoadingTaskRunner for cancel_timer_ of Resource class BUG=443374 ========== to ========== Use LoadingTaskRunner for cancel_timer_ of Resource class BUG=443374 Review-Url: https://codereview.chromium.org/2878343002 Cr-Commit-Position: refs/heads/master@{#471716} Committed: https://chromium.googlesource.com/chromium/src/+/16ed410611fef5999f2cea2eeec4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/16ed410611fef5999f2cea2eeec4... |
