Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2878333002: Make ETextModify an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ETextModify an enum class. This patch makes ETextModify an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2878333002 Cr-Commit-Position: refs/heads/master@{#471681} Committed: https://chromium.googlesource.com/chromium/src/+/e6c0fe91631379e1ce4f928d27e423ccf801a9f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-14 22:51:56 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-15 04:24:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878333002/1
3 years, 7 months ago (2017-05-15 06:16:06 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 06:20:43 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6c0fe91631379e1ce4f928d27e4...

Powered by Google App Engine
This is Rietveld 408576698