Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2878263002: Revert of Add CHECK()s about ImageLoader::has_pending_load_event_ (Closed)

Created:
3 years, 7 months ago by hiroshige
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CHECK()s about ImageLoader::has_pending_load_event_ (patchset #12 id:220001 of https://codereview.chromium.org/2859383002/ ) Reason for revert: Assertion failures in the wild and on clusterfuzz. BUG=721994 Original issue's description: > Add CHECK()s about ImageLoader::has_pending_load_event_ > > As preparation for [1], this CL checks some assumptions to hold that > are helpful for proving the equivalences in [1]. > > [1] https://codereview.chromium.org/2859093003/ > > BUG=624697, 719759 > > Review-Url: https://codereview.chromium.org/2859383002 > Cr-Commit-Position: refs/heads/master@{#471464} > Committed: https://chromium.googlesource.com/chromium/src/+/1b070387595668ec438ffec65185e61017300e3c TBR=japhet@chromium.org,yhirano@chromium.org,kinuko@chromium.org,kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624697, 719759 Review-Url: https://codereview.chromium.org/2878263002 Cr-Commit-Position: refs/heads/master@{#471598} Committed: https://chromium.googlesource.com/chromium/src/+/9d5bcf58d9932d151f12231a6544b67903780fed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 4 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hiroshige
Created Revert of Add CHECK()s about ImageLoader::has_pending_load_event_
3 years, 7 months ago (2017-05-13 18:03:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878263002/1
3 years, 7 months ago (2017-05-13 18:03:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9d5bcf58d9932d151f12231a6544b67903780fed
3 years, 7 months ago (2017-05-13 18:03:43 UTC) #6
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-05-14 03:44:04 UTC) #7
kinuko
3 years, 7 months ago (2017-05-14 22:32:49 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698