Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2878253002: Fix non-component Win-Clang build of headless_shell (Closed)

Created:
3 years, 7 months ago by hans
Modified:
3 years, 7 months ago
Reviewers:
dvallet, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-component Win-Clang build of headless_shell It was failing due to unused private member variables and an unused constant. BUG=722048 TBR=dvallet,skyostil Review-Url: https://codereview.chromium.org/2878253002 Cr-Commit-Position: refs/heads/master@{#471597} Committed: https://chromium.googlesource.com/chromium/src/+/727830d6051803fe78533922089672dfb652b3ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M headless/app/headless_shell.h View 1 chunk +3 lines, -1 line 0 comments Download
M headless/app/headless_shell.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878253002/1
3 years, 7 months ago (2017-05-13 16:48:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/727830d6051803fe78533922089672dfb652b3ac
3 years, 7 months ago (2017-05-13 17:33:18 UTC) #7
dvallet
3 years, 7 months ago (2017-05-13 21:24:37 UTC) #8
Message was sent while issue was closed.
LGTM

Sorry that I missed this
Thanks heaps for submitting a fix!

Powered by Google App Engine
This is Rietveld 408576698