Fix bug whereby OnGpuSwitched was never called

Fix bug whereby OnGpuSwitched was never called

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2878163002
Cr-Commit-Position: refs/heads/master@{#472183}
Committed: https://chromium.googlesource.com/chromium/src/+/8c3b0dd1353d36a51aab0bc5a26a85cb8506b7b4

[ccameron, 2017-05-13 03:38:30]

Description was changed from

==========
Fix bug whereby OnGpuSwitched was never called

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
==========

to

==========
Fix bug whereby OnGpuSwitched was never called

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-05-13 03:41:24]

ccameron@chromium.org changed reviewers:
+ zmo@chromium.org

[ccameron, 2017-05-13 03:41:25]

ptal

This needs to be ported to M59 (going to stable soon!), so I kept the change in
GPUInfo fairly small.

I'd like to do a bit more of a refactor on this in TOT and remove GPUInfo.gpu,
and replace it with a vector of gpus, and add an accessor primary_gpu(), to get
the primary GPU.

[ccameron, 2017-05-13 03:41:30]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 03:41:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 04:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 04:21:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Corentin Wallez, 2017-05-14 20:37:07]

On 2017/05/13 at 03:41:25, ccameron wrote:
> ptal
> 
> This needs to be ported to M59 (going to stable soon!), so I kept the change
in GPUInfo fairly small.
> 
> I'd like to do a bit more of a refactor on this in TOT and remove GPUInfo.gpu,
and replace it with a vector of gpus, and add an accessor primary_gpu(), to get
the primary GPU.

LGTM but I'm not an owner and I don't see GPUInfo::active_gpu() being used
anywhere.

[Zhenyao Mo, 2017-05-14 21:53:26]

On 2017/05/14 20:37:07, Corentin Wallez wrote:
> On 2017/05/13 at 03:41:25, ccameron wrote:
> > ptal
> > 
> > This needs to be ported to M59 (going to stable soon!), so I kept the change
> in GPUInfo fairly small.
> > 
> > I'd like to do a bit more of a refactor on this in TOT and remove
GPUInfo.gpu,
> and replace it with a vector of gpus, and add an accessor primary_gpu(), to
get
> the primary GPU.
> 
> LGTM but I'm not an owner and I don't see GPUInfo::active_gpu() being used
> anywhere.

You probably missed some changed files in this CL?
"make DisplayReconfigCallback use this" isn't in this CL.

[ccameron, 2017-05-14 23:20:02]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-14 23:20:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-05-14 23:20:26]

Oops, updated patch to include GpuDataMangerImpl changes

[commit-bot: I haz the power, 2017-05-15 00:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 00:49:46]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-05-16 00:16:33]

ping on new patçh

[ccameron, 2017-05-16 16:52:49]

ping

[Zhenyao Mo, 2017-05-16 17:10:48]

On 2017/05/16 16:52:49, ccameron wrote:
> ping

lgtm

[ccameron, 2017-05-16 17:15:52]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-16 17:15:52]

The patchset sent to the CQ was uploaded after l-g-t-m from cwallez@chromium.org
Link to the patchset: https://codereview.chromium.org/2878163002/#ps20001
(title: "Add missed file")

[commit-bot: I haz the power, 2017-05-16 17:16:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:30:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494954952074840,
"parent_rev": "81a39a3185a65ddf4b517b7c389cce6d19a8249f", "commit_rev":
"8c3b0dd1353d36a51aab0bc5a26a85cb8506b7b4"}

[commit-bot: I haz the power, 2017-05-16 19:31:01]

Description was changed from

==========
Fix bug whereby OnGpuSwitched was never called

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix bug whereby OnGpuSwitched was never called

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2878163002
Cr-Commit-Position: refs/heads/master@{#472183}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c3b0dd1353d36a51aab0bc5a26a...
==========

[commit-bot: I haz the power, 2017-05-16 19:31:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c3b0dd1353d36a51aab0bc5a26a...