mash: Serialize ShelfIDs for property conversion and transport.

ash/public/cpp/shelf_types.h

Index: ash/public/cpp/shelf_types.h
diff --git a/ash/public/cpp/shelf_types.h b/ash/public/cpp/shelf_types.h
index a198dfa94601c8962f0120268bbd662ac8a9efea..471069eb1054d0648bcce4fd435cd30b779cdce4 100644
--- a/ash/public/cpp/shelf_types.h
+++ b/ash/public/cpp/shelf_types.h
@@ -138,8 +138,8 @@ enum ShelfItemStatus {
 // As an example, a remote desktop client may want each remote application to
 // have its own icon.
 struct ASH_PUBLIC_EXPORT ShelfID {
-  ShelfID(const std::string& app_id = std::string(),
-          const std::string& launch_id = std::string());
+  explicit ShelfID(const std::string& app_id = std::string(),

[James Cook, 2017/05/15 16:37:23]

Good catch.

[msw, 2017/05/15 19:21:31]

Acknowledged.

+                   const std::string& launch_id = std::string());
   ~ShelfID();
 
   ShelfID(const ShelfID& other);
@@ -153,6 +153,10 @@ struct ASH_PUBLIC_EXPORT ShelfID {
   // This is often used to determine if the id is invalid.
   bool IsNull() const;
 
+  // Functions to [de]serialize ids as a string for window property usage, etc.
+  std::string Serialize() const;
+  static ShelfID Deserialize(const std::string* string);

[James Cook, 2017/05/15 16:37:23]

optional: Say something about validation / what happens if string is null / bad
/ etc.

[msw, 2017/05/15 19:21:31]

Done.

+
   // The application id associated with a set of windows.
   std::string app_id;
   // An id passed on app launch, to support multiple shelf items per app.