Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2878123002:
Remove component update from chrome://flags (Closed)
DescriptionRemove component update from chrome://flags
This removes Flash component updates from chrome://flags. The setting is
no longer needed as it was a temporary measure to allow testing before
the feature was enabled for users.
BUG=687752
Review-Url: https://codereview.chromium.org/2878123002
Cr-Commit-Position: refs/heads/master@{#472501}
Committed: https://chromium.googlesource.com/chromium/src/+/8a7fda6dcf9b129a883bf0b03fcb3f089cf23916
Patch Set 1 #Patch Set 2 : Rebased CL #Patch Set 3 : Rebased again #Patch Set 4 : Fix rebasing problem #
Messages
Total messages: 33 (25 generated)
kerrnel@chromium.org changed reviewers: + ihf@chromium.org
ihf, PTAL. Thanks, Greg
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Thanks and lgtm (but I am not a committer).
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== Remove component update from chrome://flags This removes Flash component updates from chrome://flags. The setting is no longer needed as it was a temporary measure to allow testing before the feature was enabled for users. BUG=687752 ========== to ========== Remove component update from chrome://flags This removes Flash component updates from chrome://flags. The setting is no longer needed as it was a temporary measure to allow testing before the feature was enabled for users. BUG=687752 ==========
kerrnel@chromium.org changed reviewers: - ihf@chromium.org
kerrnel@chromium.org changed reviewers: + ihf@chromium.org
The CQ bit was checked by kerrnel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ihf@google.com Link to the patchset: https://codereview.chromium.org/2878123002/#ps60001 (title: "Fix rebasing problem")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
kerrnel@chromium.org changed reviewers: + rsesek@chromium.org
Any committer can review this. PTAL rsesek@? Thanks, Greg
lgtm
The CQ bit was checked by kerrnel@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495039794546330,
"parent_rev": "9a2bf2fbd0047d19f8bdbfcc7c3917f5a7aad8a5", "commit_rev":
"8a7fda6dcf9b129a883bf0b03fcb3f089cf23916"}
Message was sent while issue was closed.
Description was changed from ========== Remove component update from chrome://flags This removes Flash component updates from chrome://flags. The setting is no longer needed as it was a temporary measure to allow testing before the feature was enabled for users. BUG=687752 ========== to ========== Remove component update from chrome://flags This removes Flash component updates from chrome://flags. The setting is no longer needed as it was a temporary measure to allow testing before the feature was enabled for users. BUG=687752 Review-Url: https://codereview.chromium.org/2878123002 Cr-Commit-Position: refs/heads/master@{#472501} Committed: https://chromium.googlesource.com/chromium/src/+/8a7fda6dcf9b129a883bf0b03fcb... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/8a7fda6dcf9b129a883bf0b03fcb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
