[Media Router] Create MediaSinkServiceBase and make DialMediaSinkService inherit from it

[Media Router] Create MediaSinkServiceBase and make DialMediaSinkService inherit from it

Extract some common functions from DialMediaSinkService to MediaSinkServiceBase so that CastMediaSinkService can use them.

BUG=687375
Review-Url: https://codereview.chromium.org/2878103004
Cr-Commit-Position: refs/heads/master@{#472558}
Committed: https://chromium.googlesource.com/chromium/src/+/0202e59885b64b46b56aa8d342a04fe3d3aeac8a

[zhaobin, 2017-05-13 00:52:55]

zhaobin@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2017-05-15 22:04:07]

LGTM with a couple of questions

https://codereview.chromium.org/2878103004/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/discovery/media_sink_service_base.h (right):

https://codereview.chromium.org/2878103004/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/discovery/media_sink_service_base.h:29: // Helper
function to start |finish_timer_|.
Will all media sink services have the timer-based behavior?

https://codereview.chromium.org/2878103004/diff/20001/chrome/common/media_rou...
File chrome/common/media_router/discovery/media_sink_service.h (right):

https://codereview.chromium.org/2878103004/diff/20001/chrome/common/media_rou...
chrome/common/media_router/discovery/media_sink_service.h:21: // This class is
not thread safe. All methods must be called from the IO thread.
We discussed having the DIAL proxy inherit from this class, so that the rest of
MR didn't have to know about threading implementation details of sink discovery.

In this case, this restriction can be changed to "UI thread" or removed
entirely.

[zhaobin, 2017-05-16 17:47:13]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[zhaobin, 2017-05-16 17:47:29]

https://codereview.chromium.org/2878103004/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/discovery/media_sink_service_base.h (right):

https://codereview.chromium.org/2878103004/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/discovery/media_sink_service_base.h:29: // Helper
function to start |finish_timer_|.
On 2017/05/15 22:04:07, mark a. foltz wrote:
> Will all media sink services have the timer-based behavior?

Yes, plan to implement CastMediaSinkService with timer, similar to
DialMediaSinkService.

https://codereview.chromium.org/2878103004/diff/20001/chrome/common/media_rou...
File chrome/common/media_router/discovery/media_sink_service.h (right):

https://codereview.chromium.org/2878103004/diff/20001/chrome/common/media_rou...
chrome/common/media_router/discovery/media_sink_service.h:21: // This class is
not thread safe. All methods must be called from the IO thread.
On 2017/05/15 22:04:07, mark a. foltz wrote:
> We discussed having the DIAL proxy inherit from this class, so that the rest
of
> MR didn't have to know about threading implementation details of sink
discovery.
> 
> In this case, this restriction can be changed to "UI thread" or removed
> entirely.
> 
> 

Done.

[commit-bot: I haz the power, 2017-05-16 17:48:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 17:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 17:54:10]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[zhaobin, 2017-05-16 18:29:45]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 18:31:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 20:10:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:10:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zhaobin, 2017-05-16 20:16:00]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 20:16:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 00:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:08:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zhaobin, 2017-05-17 17:38:08]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 17:39:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:18:49]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-05-17 20:21:37]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-05-17 20:21:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2878103004/#ps60001
(title: "rebase with master")

[commit-bot: I haz the power, 2017-05-17 20:22:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:53:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495052497709470,
"parent_rev": "7a0c9f84298fa7cf439feeebb32b94d3309cd87c", "commit_rev":
"da8f08bfc20bea61a7a2cdbadad34bb806289b39"}

[commit-bot: I haz the power, 2017-05-17 20:53:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495052497709470,
"parent_rev": "aa72d98b41a08607308b1f1ccb9604fff36aa432", "commit_rev":
"0202e59885b64b46b56aa8d342a04fe3d3aeac8a"}

[commit-bot: I haz the power, 2017-05-17 20:53:38]

Description was changed from

==========
[Media Router] Create MediaSinkServiceBase and make DialMediaSinkService inherit
from it

Extract some common functions from DialMediaSinkService to MediaSinkServiceBase
so that CastMediaSinkService can use them.

BUG=687375
==========

to

==========
[Media Router] Create MediaSinkServiceBase and make DialMediaSinkService inherit
from it

Extract some common functions from DialMediaSinkService to MediaSinkServiceBase
so that CastMediaSinkService can use them.

BUG=687375

Review-Url: https://codereview.chromium.org/2878103004
Cr-Commit-Position: refs/heads/master@{#472558}
Committed:
https://chromium.googlesource.com/chromium/src/+/0202e59885b64b46b56aa8d342a0...
==========

[commit-bot: I haz the power, 2017-05-17 20:53:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0202e59885b64b46b56aa8d342a0...