Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2878053003: DevTools: Find executionContextId for console message from scriptId (Closed)

Created:
3 years, 7 months ago by einbinder
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Find executionContextId for console message from scriptId Sometimes messages are created without explicit executionContextIds. For messages with scriptIds or stackTraces the executionContext can be computed. This greatly reduces the number of unattributed messages. BUG=721839 Review-Url: https://codereview.chromium.org/2878053003 Cr-Commit-Position: refs/heads/master@{#471933} Committed: https://chromium.googlesource.com/chromium/src/+/3a2590571a2bd728532c61d46ce5df3dca09cb91

Patch Set 1 #

Patch Set 2 : move into runtime #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
einbinder
ptal
3 years, 7 months ago (2017-05-12 18:08:13 UTC) #3
pfeldman
lgtm, but move to RuntimeModel.
3 years, 7 months ago (2017-05-13 01:00:08 UTC) #8
pfeldman
lgtm
3 years, 7 months ago (2017-05-15 20:19:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878053003/20001
3 years, 7 months ago (2017-05-15 20:40:05 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 22:42:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a2590571a2bd728532c61d46ce5...

Powered by Google App Engine
This is Rietveld 408576698