Issue 2878050: AutoFill credit card settings dialog should display obfuscated number in edit field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2878050: AutoFill credit card settings dialog should display obfuscated number in edit field (Closed)

Created:
10 years, 5 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill credit card settings dialog should display obfuscated number in edit field Changes the AutoFillTextField class to properly initialize obfuscated credit card text in text field on the credit card editor sheet. Adds additional unit tests to verify that obfuscated text appears to the user. Nib changes: Adds outlet for the credit card number text field for use in unit tests. BUG=49988 TEST=AutoFillDialogControllerTest.CreditCardDataMutation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53489

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -18 lines)			Patch
M	chrome/app/nibs/AutoFillCreditCardSheet.xib	View	9 chunks	+43 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_text_field_mac.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_text_field_mac.mm	View	2 chunks	+10 lines, -13 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

10 years, 5 months ago (2010-07-23 17:25:06 UTC) #1

LGTM.  It was a little odd to see "[self setObjectValue:[self objectValue]]",
but it makes sense...

Expand Messages | Collapse Messages