Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.h

Issue 2878050: AutoFill credit card settings dialog should display obfuscated number in edit field (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_CREDIT_CARD_SHEET_CONTROLLER_MAC_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_CREDIT_CARD_SHEET_CONTROLLER_MAC_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_CREDIT_CARD_SHEET_CONTROLLER_MAC_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_CREDIT_CARD_SHEET_CONTROLLER_MAC_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 @class AutoFillCreditCardModel; 10 @class AutoFillCreditCardModel;
(...skipping 15 matching lines...) Expand all
26 @interface AutoFillCreditCardSheetController : NSWindowController { 26 @interface AutoFillCreditCardSheetController : NSWindowController {
27 @private 27 @private
28 IBOutlet NSPopUpButton* billingAddressPopup_; 28 IBOutlet NSPopUpButton* billingAddressPopup_;
29 IBOutlet NSPopUpButton* expirationMonthPopup_; 29 IBOutlet NSPopUpButton* expirationMonthPopup_;
30 IBOutlet NSPopUpButton* expirationYearPopup_; 30 IBOutlet NSPopUpButton* expirationYearPopup_;
31 31
32 // The caption at top of dialog. Text changes according to usage. Either 32 // The caption at top of dialog. Text changes according to usage. Either
33 // "New credit card" or "Edit credit card" depending on context. 33 // "New credit card" or "Edit credit card" depending on context.
34 IBOutlet NSTextField* caption_; 34 IBOutlet NSTextField* caption_;
35 35
36 // The credit card number field. This is here for unit testing purposes.
37 // The text of this field is obfuscated until edited.
38 IBOutlet NSTextField* creditCardNumberField_;
39
36 // The primary model for this controller. The model is instantiated 40 // The primary model for this controller. The model is instantiated
37 // from within |initWithCreditCard:|. We do not hold it as a scoped_nsobject 41 // from within |initWithCreditCard:|. We do not hold it as a scoped_nsobject
38 // because it is exposed as a KVO compliant property. 42 // because it is exposed as a KVO compliant property.
39 AutoFillCreditCardModel* creditCardModel_; 43 AutoFillCreditCardModel* creditCardModel_;
40 44
41 // Array of strings that populate the |billingAddressPopup_| control. We 45 // Array of strings that populate the |billingAddressPopup_| control. We
42 // do not hold this as scoped_nsobject because it is exposed as a KVO 46 // do not hold this as scoped_nsobject because it is exposed as a KVO
43 // compliant property. The values of this array may change as the list 47 // compliant property. The values of this array may change as the list
44 // of addresses change in the |parentController_|. 48 // of addresses change in the |parentController_|.
45 NSArray* billingAddressContents_; 49 NSArray* billingAddressContents_;
(...skipping 26 matching lines...) Expand all
72 76
73 // IBActions for save and cancel buttons. Both invoke |endSheet:|. 77 // IBActions for save and cancel buttons. Both invoke |endSheet:|.
74 - (IBAction)save:(id)sender; 78 - (IBAction)save:(id)sender;
75 - (IBAction)cancel:(id)sender; 79 - (IBAction)cancel:(id)sender;
76 80
77 // Copy data from internal model to |creditCard|. 81 // Copy data from internal model to |creditCard|.
78 - (void)copyModelToCreditCard:(CreditCard*)creditCard; 82 - (void)copyModelToCreditCard:(CreditCard*)creditCard;
79 83
80 @end 84 @end
81 85
86 // Interface exposed for unit testing.
87 @interface AutoFillCreditCardSheetController (ExposedForUnitTests)
88 - (NSTextField*)creditCardNumberField;
89 @end
90
82 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_CREDIT_CARD_SHEET_CONTROLLER_MAC_ 91 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_CREDIT_CARD_SHEET_CONTROLLER_MAC_
OLDNEW
« no previous file with comments | « chrome/app/nibs/AutoFillCreditCardSheet.xib ('k') | chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698