Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2877983002: Use search_term_value_prefix_ & search_term_value_suffix_ to specify the location of {searchTerms} … (Closed)

Created:
3 years, 7 months ago by Vitaly Baranov
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use search_term_value_prefix_ & search_term_value_suffix_ to specify the location of {searchTerms} in URL path as well. R=pkasting@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2877983002 Cr-Commit-Position: refs/heads/master@{#471749} Committed: https://chromium.googlesource.com/chromium/src/+/f2a115696f2e24d9e8d174637f192497fbbdf554

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add DISALLOW_COPY_AND_ASSIGN #

Patch Set 3 : Fix unit-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -132 lines) Patch
M components/search_engines/template_url.h View 2 chunks +13 lines, -8 lines 0 comments Download
M components/search_engines/template_url.cc View 1 7 chunks +96 lines, -89 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 1 2 3 chunks +44 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Vitaly Baranov
3 years, 7 months ago (2017-05-12 15:12:16 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/2877983002/diff/1/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/2877983002/diff/1/components/search_engines/template_url.cc#newcode155 components/search_engines/template_url.cc:155: }; Nit: DISALLOW_COPY_AND_ASSIGN
3 years, 7 months ago (2017-05-12 21:17:47 UTC) #2
Vitaly Baranov
https://codereview.chromium.org/2877983002/diff/1/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/2877983002/diff/1/components/search_engines/template_url.cc#newcode155 components/search_engines/template_url.cc:155: }; On 2017/05/12 21:17:46, Peter Kasting wrote: > Nit: ...
3 years, 7 months ago (2017-05-15 07:55:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877983002/20001
3 years, 7 months ago (2017-05-15 07:55:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/214726)
3 years, 7 months ago (2017-05-15 08:24:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877983002/40001
3 years, 7 months ago (2017-05-15 12:59:07 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 14:10:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f2a115696f2e24d9e8d174637f19...

Powered by Google App Engine
This is Rietveld 408576698