|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by fserb Modified:
3 years, 7 months ago Reviewers:
Justin Novosad CC:
blink-reviews, Rik, chromium-reviews, dshwang, haraken Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable 2D canvas deferral on text rendering when compositing
SkPicture currently has a hard time realizing a surface change may mean
a LCD font rendering change. So we can't send deferred SkPicture when
drawing texts
BUG=682074
Review-Url: https://codereview.chromium.org/2877833002
Cr-Commit-Position: refs/heads/master@{#471808}
Committed: https://chromium.googlesource.com/chromium/src/+/ee1c820d0133c0536a55b5a0aaf808a97c471bde
Patch Set 1 #Patch Set 2 : x #Patch Set 3 : x #Patch Set 4 : x #
Messages
Total messages: 38 (21 generated)
fserb@chromium.org changed reviewers: + junov@chromium.org
The CQ bit was checked by fserb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
FYI, removing the test that tests that we don't do what we are doing now.
The CQ bit was checked by fserb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/2877833002/#ps20001 (title: "x")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fserb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/2877833002/#ps40001 (title: "x")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fserb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/2877833002/#ps60001 (title: "x")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494859669577070,
"parent_rev": "416588f2ea472b4f9273cbd0e40c1d18f71d1cba", "commit_rev":
"ee1c820d0133c0536a55b5a0aaf808a97c471bde"}
Message was sent while issue was closed.
Description was changed from ========== Disable 2D canvas deferral on text rendering when compositing SkPicture currently has a hard time realizing a surface change may mean a LCD font rendering change. So we can't send deferred SkPicture when drawing texts BUG=682074 ========== to ========== Disable 2D canvas deferral on text rendering when compositing SkPicture currently has a hard time realizing a surface change may mean a LCD font rendering change. So we can't send deferred SkPicture when drawing texts BUG=682074 Review-Url: https://codereview.chromium.org/2877833002 Cr-Commit-Position: refs/heads/master@{#471808} Committed: https://chromium.googlesource.com/chromium/src/+/ee1c820d0133c0536a55b5a0aaf8... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ee1c820d0133c0536a55b5a0aaf8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
