Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2877823002: Update defaults for parsing filters in OffscreenCanvas (Closed)

Created:
3 years, 7 months ago by fserb
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, ikilpatrick, rwlbuis, Tab Atkins
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update defaults for parsing filters in OffscreenCanvas changes default em font size to 16 changes default viewport size to 0x0 BUG=721498 Review-Url: https://codereview.chromium.org/2877823002 Cr-Commit-Position: refs/heads/master@{#471104} Committed: https://chromium.googlesource.com/chromium/src/+/9a2b08a274957c88fb82ed1f24edf1f841c01d19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fserb
3 years, 7 months ago (2017-05-11 18:11:20 UTC) #2
Justin Novosad
lgtm with a crbug added to the description
3 years, 7 months ago (2017-05-11 19:20:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877823002/1
3 years, 7 months ago (2017-05-11 19:22:41 UTC) #9
ikilpatrick
lgtm, thanks for changing this.
3 years, 7 months ago (2017-05-11 22:56:47 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:57:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a2b08a274957c88fb82ed1f24ed...

Powered by Google App Engine
This is Rietveld 408576698