Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2877803003: Remove v8.top_25_smooth & v8.key_mobile_sites_smooth benchmarks (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove v8.top_25_smooth & v8.key_mobile_sites_smooth benchmarks These real world v8 benchmarks are now better covered by v8.browsing_desktop & v8.browsing_mobile. BUG=721413 Review-Url: https://codereview.chromium.org/2877803003 Cr-Commit-Position: refs/heads/master@{#471772} Committed: https://chromium.googlesource.com/chromium/src/+/12b214a95fb98f5ce9eb412d28cda654f49b4d08

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -1463 lines) Patch
M testing/buildbot/chromium.perf.json View 1 2 30 chunks +193 lines, -1196 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 1 2 4 chunks +0 lines, -236 lines 0 comments Download
M tools/perf/benchmark.csv View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 2 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 29 (20 generated)
nednguyen
3 years, 7 months ago (2017-05-11 16:51:11 UTC) #6
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-15 09:19:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877803003/20001
3 years, 7 months ago (2017-05-15 10:34:46 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-15 10:34:48 UTC) #17
rmcilroy
On 2017/05/15 10:34:48, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 7 months ago (2017-05-15 12:34:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877803003/20001
3 years, 7 months ago (2017-05-15 12:49:27 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/268819)
3 years, 7 months ago (2017-05-15 12:52:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877803003/40001
3 years, 7 months ago (2017-05-15 13:54:42 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 15:34:40 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/12b214a95fb98f5ce9eb412d28cd...

Powered by Google App Engine
This is Rietveld 408576698