Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2877773002: Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender (Closed)

Created:
6 months, 2 weeks ago by Chandan
Modified:
6 months, 1 week ago
Reviewers:
miu
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, net-reviews_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender PacedSender already creates a WeakPtrFactory instance to access its weak pointer. Therefore, it does not have to inherit base::SupportsWeakPtr. base::NonThreadSafe has been deprecated. BUG=None Review-Url: https://codereview.chromium.org/2877773002 Cr-Commit-Position: refs/heads/master@{#472758} Committed: https://chromium.googlesource.com/chromium/src/+/1f8c3c6594c391e8ce45f20a851f049fde6678cd

Patch Set 1 #

Patch Set 2 : Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/cast/net/pacing/paced_sender.h View 1 1 chunk +1 line, -3 lines 0 comments Download
Trybot results:  chromium_presubmit   win_chromium_rel_ng   win_chromium_rel_ng   linux_android_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   ios-device-xcode-clang   ios-simulator   ios-simulator-xcode-clang   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   ios-device   linux_chromium_tsan_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   cast_shell_linux   linux_android_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_clang_dbg_recipe   android_arm64_dbg_recipe   android_compile_dbg   win_chromium_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   android_n5x_swarming_rel   cast_shell_android   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 

Messages

Total messages: 25 (19 generated)
Chandan
PTAL. Thank you.
6 months, 1 week ago (2017-05-16 13:22:53 UTC) #13
miu
lgtm
6 months, 1 week ago (2017-05-18 02:55:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877773002/20001
6 months, 1 week ago (2017-05-18 02:57:35 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448252)
6 months, 1 week ago (2017-05-18 08:01:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877773002/20001
6 months, 1 week ago (2017-05-18 08:28:41 UTC) #22
commit-bot: I haz the power
6 months, 1 week ago (2017-05-18 10:13:29 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f8c3c6594c391e8ce45f20a851f...

Powered by Google App Engine
This is Rietveld efc10ee0f