Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2877773002:
Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender (Closed)
|
Created:
3 years, 7 months ago by Chandan Modified:
3 years, 7 months ago Reviewers:
miu CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, net-reviews_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender
PacedSender already creates a WeakPtrFactory instance to access its weak
pointer. Therefore, it does not have to inherit base::SupportsWeakPtr.
base::NonThreadSafe has been deprecated.
BUG=None
Review-Url: https://codereview.chromium.org/2877773002
Cr-Commit-Position: refs/heads/master@{#472758}
Committed: https://chromium.googlesource.com/chromium/src/+/1f8c3c6594c391e8ce45f20a851f049fde6678cd
Patch Set 1 #Patch Set 2 : Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender #Messages
Total messages: 25 (19 generated)
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove base::SupportsWeakPtr from PacedSender PacedSender already creates a WeakPtrFactory instance to access its weak pointer. Therefore, it does not have to inherit base::SupportsWeakPtr. BUG=None ========== to ========== Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender PacedSender already creates a WeakPtrFactory instance to access its weak pointer. Therefore, it does not have to inherit base::SupportsWeakPtr. base::NonThreadSafe has been deprecated. BUG=None ==========
c.padhi@samsung.com changed reviewers: + miu@chromium.org
PTAL. Thank you.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by miu@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by c.padhi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495096090193740,
"parent_rev": "2c8452ad5808e8466b92449340e199c334e3b991", "commit_rev":
"1f8c3c6594c391e8ce45f20a851f049fde6678cd"}
Message was sent while issue was closed.
Description was changed from ========== Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender PacedSender already creates a WeakPtrFactory instance to access its weak pointer. Therefore, it does not have to inherit base::SupportsWeakPtr. base::NonThreadSafe has been deprecated. BUG=None ========== to ========== Remove base::SupportsWeakPtr and base::NonThreadSafe from PacedSender PacedSender already creates a WeakPtrFactory instance to access its weak pointer. Therefore, it does not have to inherit base::SupportsWeakPtr. base::NonThreadSafe has been deprecated. BUG=None Review-Url: https://codereview.chromium.org/2877773002 Cr-Commit-Position: refs/heads/master@{#472758} Committed: https://chromium.googlesource.com/chromium/src/+/1f8c3c6594c391e8ce45f20a851f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1f8c3c6594c391e8ce45f20a851f... |
