Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2877743002: 📱 Cleanup definition of ActivityState and ApplicationStatus warnings (Closed)

Created:
3 years, 7 months ago by dgn
Modified:
3 years, 7 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup definition of ActivityState and ApplicationStatus warnings Removed the redundant ActivityStateEnum intdef definition and resolved lint warnings in the ActivityState and ApplicationStatus classes. Also updated the c++ enum conversion doc about the new IntDef declaration style that was added in https://crrev.com/14f477472e0e8612c98763b68e9a51bcae954c24 BUG=707186 Review-Url: https://codereview.chromium.org/2877743002 Cr-Commit-Position: refs/heads/master@{#471432} Committed: https://chromium.googlesource.com/chromium/src/+/2b5c5e827022eb7f91ae9036181151576c0ade65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -42 lines) Patch
M base/android/java/src/org/chromium/base/ActivityState.java View 1 chunk +10 lines, -12 lines 0 comments Download
M base/android/java/src/org/chromium/base/ApplicationStatus.java View 11 chunks +14 lines, -17 lines 0 comments Download
M docs/android_accessing_cpp_enums_in_java.md View 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dgn
PTAL
3 years, 7 months ago (2017-05-11 11:03:51 UTC) #5
rmcilroy
LGTM, thanks.
3 years, 7 months ago (2017-05-12 16:19:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877743002/1
3 years, 7 months ago (2017-05-12 16:26:19 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 20:34:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b5c5e827022eb7f91ae90361811...

Powered by Google App Engine
This is Rietveld 408576698