Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/perf/measurements/measurement_unittest.py

Issue 287773002: [telemetry] Make testMeasurementSmoke generate separate tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix @Disabled Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/telemetry/telemetry/page/gtest_test_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/measurement_unittest.py
diff --git a/tools/perf/measurements/measurement_unittest.py b/tools/perf/measurements/measurement_unittest.py
deleted file mode 100644
index 7fbcad010a4650ed6b7c6dde00b23ffd50be36ba..0000000000000000000000000000000000000000
--- a/tools/perf/measurements/measurement_unittest.py
+++ /dev/null
@@ -1,73 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import logging
-import os
-import unittest
-
-from telemetry import test
-from telemetry.core import discover
-from telemetry.page import page_measurement
-from telemetry.unittest import options_for_unittests
-
-
-class MeasurementUnitTest(unittest.TestCase):
-
- # TODO(achuith): Fix crbug.com/351114.
- @test.Disabled('android', 'chromeos', 'win')
- def testMeasurementSmoke(self):
- # Run all Measurements against the first Page in the PageSet of the first
- # Benchmark that uses them.
- #
- # Ideally this test would be comprehensive, but the above serves as a
- # kind of smoke test.
- measurements_dir = os.path.dirname(__file__)
- top_level_dir = os.path.dirname(measurements_dir)
- benchmarks_dir = os.path.join(top_level_dir, 'benchmarks')
-
- all_measurements = discover.DiscoverClasses(
- measurements_dir, top_level_dir, page_measurement.PageMeasurement,
- pattern='*.py').values()
- all_benchmarks = discover.DiscoverClasses(
- benchmarks_dir, top_level_dir, test.Test, pattern='*.py').values()
-
- for benchmark in all_benchmarks:
- if benchmark.test not in all_measurements:
- # If the benchmark is not in measurements, then it is not composable.
- # Ideally we'd like to test these as well, but the non-composable
- # benchmarks are usually long-running benchmarks.
- continue
-
- if hasattr(benchmark, 'generated_profile_archive'):
- # We'd like to test these, but don't know how yet.
- continue
-
- # Only measure a single page so that this test cycles reasonably quickly.
- benchmark.options['pageset_repeat'] = 1
- benchmark.options['page_repeat'] = 1
-
- class SinglePageBenchmark(benchmark): # pylint: disable=W0232
- def CreatePageSet(self, options):
- # pylint: disable=E1002
- ps = super(SinglePageBenchmark, self).CreatePageSet(options)
- ps.pages = ps.pages[:1]
- return ps
-
- logging.info('running: %s', benchmark)
-
- # Set the benchmark's default arguments.
- options = options_for_unittests.GetCopy()
- options.output_format = 'none'
- parser = options.CreateParser()
-
- benchmark.AddCommandLineArgs(parser)
- test.AddCommandLineArgs(parser)
- benchmark.SetArgumentDefaults(parser)
- options.MergeDefaultValues(parser.get_default_values())
-
- benchmark.ProcessCommandLineArgs(None, options)
- test.ProcessCommandLineArgs(None, options)
-
- self.assertEqual(0, SinglePageBenchmark().Run(options),
- msg='Failed: %s' % benchmark)
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/telemetry/telemetry/page/gtest_test_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698