Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2877703006: Add functions to convert boolean jni array. (Closed)

Created:
3 years, 7 months ago by vitaliii
Modified:
3 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add functions to convert boolean jni array. This CL adds functions to convert: - const bool* -> jbooleanArray - jbooleanArray -> std::vector<bool> BUG=None Review-Url: https://codereview.chromium.org/2877703006 Cr-Commit-Position: refs/heads/master@{#471708} Committed: https://chromium.googlesource.com/chromium/src/+/f5491927bfe64f169602cecea4600f6b73568dc2

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -10 lines) Patch
M base/android/jni_array.h View 2 chunks +9 lines, -0 lines 0 comments Download
M base/android/jni_array.cc View 9 chunks +38 lines, -9 lines 0 comments Download
M base/android/jni_array_unittest.cc View 1 2 3 chunks +58 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_backup_agent.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 25 (21 generated)
vitaliii
Hi nyquist@, Could you have a look please?
3 years, 7 months ago (2017-05-12 14:57:31 UTC) #13
nyquist
lgtm
3 years, 7 months ago (2017-05-12 23:22:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877703006/60001
3 years, 7 months ago (2017-05-15 09:06:30 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 09:11:23 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f5491927bfe64f169602cecea460...

Powered by Google App Engine
This is Rietveld 408576698