Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2877703004: Whitelist voice_icon as not found image (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), jif
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist voice_icon as not found image voice_icon is not available upstream but it is used in thecode. This CL adds it as an exception. BUG=721338 TBR=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2877703004 Cr-Commit-Position: refs/heads/master@{#470955} Committed: https://chromium.googlesource.com/chromium/src/+/c485baf2b38d83473ebf49c40c81b95115d8d383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/app/startup/setup_debugging.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
gambard
PTAL.
3 years, 7 months ago (2017-05-11 14:02:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877703004/1
3 years, 7 months ago (2017-05-11 14:43:28 UTC) #9
sdefresne
lgtm
3 years, 7 months ago (2017-05-11 14:44:41 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 14:49:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c485baf2b38d83473ebf49c40c81...

Powered by Google App Engine
This is Rietveld 408576698