Upstream service worker opaque-response-preloaded.https.html test to WPT

Upstream service worker opaque-response-preloaded.https.html test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116, 625575
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2877673004
Cr-Commit-Position: refs/heads/master@{#471341}
Committed: https://chromium.googlesource.com/chromium/src/+/7794609a04bdf904491f8d9501f6cd5ecf39adde

[mike3, 2017-05-11 16:04:37]

Hi Mek,

This is another test that may be too specific for upstreaming to WPT. I'm
submitting it anyway, in case seeing the generalized version makes it easier to
decide. Here's the diff:

https://gist.github.com/jugglinmike/42f92cce3c3d77cc016acedcc3ae43ed

What do you think?

[falken, 2017-05-12 05:04:20]

falken@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2017-05-12 05:04:21]

this lgtm

The title could be more descriptive. Maybe just "Upstream service worker
opaque-response-preloaded.https.html test to WPT"

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/opaque-response-preloaded.https.html
(right):

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/opaque-response-preloaded.https.html:19:
// chunk.
This comment was copy/pasted from another test :(

We should do better. "This tests that the browser does not inappropriately use a
cached opaque response for a request that is not no-cors. The test opens a
controlled iframe that uses link rel=preload to issue a same-origin no-cors
request. The service worker responds to the request with an opaque response.
Then the iframe does an XHR (not no-cors) to that URL again. The request should
fail."

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/opaque-response-preloaded-iframe.html
(right):

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/opaque-response-preloaded-iframe.html:6:
var l = document.createElement('link');
I originally missed this critical part of the test. Add a comment here like:
"Use link rel=preload to try to get the browser to cache the opaque response."

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/opaque-response-preloaded-iframe.html:15:
// Particularly, the XHR must not reuse the preloaded the opaque response.
"the preloaded the" is hard to read.

"reuse the opaque response from the preload request"

[falken, 2017-05-12 05:14:14]

Also add 625575 to the BUG list.

[mike3, 2017-05-12 15:25:10]

Description was changed from

==========
Upstream service worker response test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116
R=mek@chromium.org
==========

to

==========
Upstream service worker response test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116, 625575
R=falken@chromium.org
==========

[mike3, 2017-05-12 15:36:03]

Thanks, Matt!

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/opaque-response-preloaded.https.html
(right):

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/opaque-response-preloaded.https.html:19:
// chunk.
On 2017/05/12 05:04:21, falken wrote:
> This comment was copy/pasted from another test :(
> 
> We should do better. "This tests that the browser does not inappropriately use
a
> cached opaque response for a request that is not no-cors. The test opens a
> controlled iframe that uses link rel=preload to issue a same-origin no-cors
> request. The service worker responds to the request with an opaque response.
> Then the iframe does an XHR (not no-cors) to that URL again. The request
should
> fail."

Done.

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/opaque-response-preloaded-iframe.html
(right):

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/opaque-response-preloaded-iframe.html:6:
var l = document.createElement('link');
On 2017/05/12 05:04:21, falken wrote:
> I originally missed this critical part of the test. Add a comment here like:
> "Use link rel=preload to try to get the browser to cache the opaque response."

Done.

https://codereview.chromium.org/2877673004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/opaque-response-preloaded-iframe.html:15:
// Particularly, the XHR must not reuse the preloaded the opaque response.
On 2017/05/12 05:04:21, falken wrote:
> "the preloaded the" is hard to read.
> 
> "reuse the opaque response from the preload request"

Done.

[mike3, 2017-05-12 15:36:55]

The CQ bit was checked by mike@mikepennisi.com

[mike3, 2017-05-12 15:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2877673004/#ps20001
(title: "Incorporate review feedback")

[commit-bot: I haz the power, 2017-05-12 15:37:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mike3, 2017-05-12 15:42:24]

Description was changed from

==========
Upstream service worker response test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116, 625575
R=falken@chromium.org
==========

to

==========
Upstream service worker opaque-response-preloaded.https.html test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116, 625575
R=falken@chromium.org
==========

[commit-bot: I haz the power, 2017-05-12 16:58:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494603415425430,
"parent_rev": "6f323a5f1fd9ad313745573f945739541dd40161", "commit_rev":
"7794609a04bdf904491f8d9501f6cd5ecf39adde"}

[commit-bot: I haz the power, 2017-05-12 16:58:48]

Description was changed from

==========
Upstream service worker opaque-response-preloaded.https.html test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116, 625575
R=falken@chromium.org
==========

to

==========
Upstream service worker opaque-response-preloaded.https.html test to WPT

- Re-locate file for eventual submission to the Web Platform Tests
  project
- Add "clean up" logic to remove iframe from document
- Remove implementation-specific details from in-line documentation

BUG=688116, 625575
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2877673004
Cr-Commit-Position: refs/heads/master@{#471341}
Committed:
https://chromium.googlesource.com/chromium/src/+/7794609a04bdf904491f8d9501f6...
==========

[commit-bot: I haz the power, 2017-05-12 16:58:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7794609a04bdf904491f8d9501f6...