[cipd] stop doing weird ownership transfer

[cipd] stop doing weird ownership transfer

R=vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2877643002
Committed: https://github.com/luci/luci-go/commit/71d28416735bdd47590741cf4682c874f3c6fd4c

[iannucci, 2017-05-11 02:17:01]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 02:17:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-05-11 02:22:18]

oh, forgot to send, PTAL

[Vadim Sh., 2017-05-11 02:22:44]

https://codereview.chromium.org/2877643002/diff/1/cipd/client/cipd/local/read...
File cipd/client/cipd/local/reader.go (right):

https://codereview.chromium.org/2877643002/diff/1/cipd/client/cipd/local/read...
cipd/client/cipd/local/reader.go:69: func OpenInstanceFile(ctx context.Context,
path string, instanceID string, v VerificationMode) (inst PackageInstance,
closer func() error, err error) {
Maybe we should get rid of OpenInstanceFile?

cognitive overhead of "closer" is higher than just copy-pasting this trivial
logic in place where it is used

[commit-bot: I haz the power, 2017-05-11 02:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:23:36]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-05-11 02:24:46]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[iannucci, 2017-05-11 02:24:50]

https://codereview.chromium.org/2877643002/diff/1/cipd/client/cipd/local/read...
File cipd/client/cipd/local/reader.go (right):

https://codereview.chromium.org/2877643002/diff/1/cipd/client/cipd/local/read...
cipd/client/cipd/local/reader.go:69: func OpenInstanceFile(ctx context.Context,
path string, instanceID string, v VerificationMode) (inst PackageInstance,
closer func() error, err error) {
On 2017/05/11 02:22:44, Vadim Sh. wrote:
> Maybe we should get rid of OpenInstanceFile?
> 
> cognitive overhead of "closer" is higher than just copy-pasting this trivial
> logic in place where it is used

Eh, I don't think closer is too bad, tbh. I'll update the comment though.

[commit-bot: I haz the power, 2017-05-11 02:24:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vadim Sh., 2017-05-11 02:28:17]

lgtm with nit

https://codereview.chromium.org/2877643002/diff/20001/cipd/client/cipd/local/...
File cipd/client/cipd/local/reader.go (right):

https://codereview.chromium.org/2877643002/diff/20001/cipd/client/cipd/local/...
cipd/client/cipd/local/reader.go:81: closer = file.Close
let's return nil as inst and closer in case of err != nil.

Not sure why I didn't do it before. Probably was saving lines :)

[commit-bot: I haz the power, 2017-05-11 02:31:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:31:28]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-05-11 02:46:19]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-05-11 02:46:20]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2877643002/#ps40001
(title: "fix nit")

[commit-bot: I haz the power, 2017-05-11 02:46:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-05-11 02:46:29]

https://codereview.chromium.org/2877643002/diff/20001/cipd/client/cipd/local/...
File cipd/client/cipd/local/reader.go (right):

https://codereview.chromium.org/2877643002/diff/20001/cipd/client/cipd/local/...
cipd/client/cipd/local/reader.go:81: closer = file.Close
On 2017/05/11 02:28:17, Vadim Sh. wrote:
> let's return nil as inst and closer in case of err != nil.
> 
> Not sure why I didn't do it before. Probably was saving lines :)

Done.

[commit-bot: I haz the power, 2017-05-11 02:53:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494470779950780,
"parent_rev": "0eb69ab195d7c4a88cd41d26b53f9a868c15713f", "commit_rev":
"71d28416735bdd47590741cf4682c874f3c6fd4c"}

[commit-bot: I haz the power, 2017-05-11 02:53:21]

Description was changed from

==========
[cipd] stop doing weird ownership transfer

R=vadimsh@chromium.org
BUG=
==========

to

==========
[cipd] stop doing weird ownership transfer

R=vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2877643002
Committed:
https://github.com/luci/luci-go/commit/71d28416735bdd47590741cf4682c874f3c6fd4c
==========

[commit-bot: I haz the power, 2017-05-11 02:53:22]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/71d28416735bdd47590741cf4682c874f3c6fd4c