Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2877573002: [Mac] Fix race condition in memory pressure level reporting. (Closed)

Created:
3 years, 7 months ago by shrike
Modified:
3 years, 7 months ago
Reviewers:
Mark Mentovai, brettw
CC:
chromium-reviews, danakj+watch_chromium.org, chrome-grc-reviews+memory_chromium.org, gavinp+memory_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix race condition in memory pressure level reporting. The change in https://codereview.chromium.org/2743253006 stops the Mac memory pressure monitor from checking the current pressure level directly on each call to GetCurrentPressureLevel(). However, if the OS sends a pressure change notification, callers of GetCurrentPressureLevel() may receive the old pressure level. This cl fixes the race condition by forcing an internal pressure level update upon receiving a pressure level change notification from the OS. R=brettw@chromium.org,mark@chromium.org BUG=720924 Review-Url: https://codereview.chromium.org/2877573002 Cr-Commit-Position: refs/heads/master@{#472171} Committed: https://chromium.googlesource.com/chromium/src/+/fb11bbe1e11b29ad870bdf5a940847dda841f542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M base/memory/memory_pressure_monitor_mac.cc View 1 chunk +8 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shrike
PTAL - I tested before and after using the memory_pressure utility, so I believe this ...
3 years, 7 months ago (2017-05-10 21:32:35 UTC) #1
brettw
lgtm
3 years, 7 months ago (2017-05-11 16:54:42 UTC) #2
shrike
mark@ - requesting owners approval
3 years, 7 months ago (2017-05-11 18:37:27 UTC) #5
shrike
On 2017/05/11 18:37:27, shrike wrote: > mark@ - requesting owners approval mark@ - gentle ping
3 years, 7 months ago (2017-05-16 16:28:37 UTC) #6
Mark Mentovai
LGTM
3 years, 7 months ago (2017-05-16 17:11:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877573002/1
3 years, 7 months ago (2017-05-16 17:30:14 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 18:30:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb11bbe1e11b29ad870bdf5a9408...

Powered by Google App Engine
This is Rietveld 408576698