Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2877553003: Network services: add tools/perf/contrib/network_service. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network services: add tools/perf/contrib/network_service. The folder will be used to host benchmarks for measuring perf of Chrome with the network service enabled. Eventually we won't need this folder when the network service is enabled by default and the old network-in-browser-process code path is removed. BUG=717738, 598073 R=nednguyen@google.com Review-Url: https://codereview.chromium.org/2877553003 . Cr-Commit-Position: refs/heads/master@{#471048} Committed: https://chromium.googlesource.com/chromium/src/+/5bab1b8217a0045f0c949ba3ae6ffc864e3b8732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A tools/perf/contrib/network_service/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yzshen1
Hi, Ned. Would you please take a look? Thanks!
3 years, 7 months ago (2017-05-11 17:50:50 UTC) #2
nednguyen
On 2017/05/11 17:50:50, yzshen1 wrote: > Hi, Ned. > > Would you please take a ...
3 years, 7 months ago (2017-05-11 19:16:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877553003/1
3 years, 7 months ago (2017-05-11 19:20:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/434428)
3 years, 7 months ago (2017-05-11 19:34:38 UTC) #7
yzshen1
3 years, 7 months ago (2017-05-11 19:48:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bab1b8217a0045f0c949ba3ae6ffc864e3b8732.

Powered by Google App Engine
This is Rietveld 408576698