Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2877523002: Fix scriptprocessornode-rewrap.html (Closed)

Created:
3 years, 7 months ago by hongchan
Modified:
3 years, 7 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix scriptprocessornode-rewrap.html The structure of this test was outdated and broken. This CL sanitize the test so we can apply the batch clean-up tool in the future. BUG=720537 TEST=LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-rewrap.html Review-Url: https://codereview.chromium.org/2877523002 Cr-Commit-Position: refs/heads/master@{#473016} Committed: https://chromium.googlesource.com/chromium/src/+/926e3b8b4f6523331bb200c6665bb953acc91134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-rewrap.html View 1 chunk +26 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hongchan
PTAL. Turned out to be this is the only test fails on layout-test-tidy.
3 years, 7 months ago (2017-05-10 18:15:05 UTC) #2
Raymond Toy
lgtm
3 years, 7 months ago (2017-05-10 18:22:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877523002/1
3 years, 7 months ago (2017-05-17 21:19:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458022)
3 years, 7 months ago (2017-05-17 23:41:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877523002/1
3 years, 7 months ago (2017-05-18 22:38:09 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:31:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/926e3b8b4f6523331bb200c6665b...

Powered by Google App Engine
This is Rietveld 408576698