Reland "named caches: move instead of symlinking"

Reland "named caches: move instead of symlinking"

This relands d1ab255eac4e9ef88d437d476a586d22cda15952
with fixed tests.

BUG=715326
Review-Url: https://codereview.chromium.org/2877483004
Committed: https://github.com/luci/luci-py/commit/b551d1cc05919318aa1d643cfa174a2e2c451ae8

[nodir, 2017-05-11 17:31:51]

Description was changed from

==========
Reland "named caches: move instead of symlinking"

This relands d1ab255eac4e9ef88d437d476a586d22cda15952
with fixed tests.

BUG=
==========

to

==========
Reland "named caches: move instead of symlinking"

This relands d1ab255eac4e9ef88d437d476a586d22cda15952
with fixed tests.

BUG=715326
==========

[nodir, 2017-05-11 18:45:37]

PTAL

[nodir, 2017-05-11 19:50:37]

nodir@chromium.org changed reviewers:
+ maruel@chromium.org

[nodir, 2017-05-11 19:50:37]

+maruel

[M-A Ruel, 2017-05-11 19:55:14]

lgtm

https://codereview.chromium.org/2877483004/diff/60001/appengine/swarming/swar...
File appengine/swarming/swarming_bot/bot_code/task_runner_test.py (right):

https://codereview.chromium.org/2877483004/diff/60001/appengine/swarming/swar...
appengine/swarming/swarming_bot/bot_code/task_runner_test.py:603: with
tmpinstall(), open(os.path.join(install_dir, 'bar'), 'wb') as f:
Why not:
with cache_manager.open():
  cache_manager.install(install_dir, 'foo')
  with open(os.path.join(install_dir, 'bar'), 'wb') as f:
    f.write('thecache')
  cache_manager.uninstall(install_dir, 'foo')

it's shorter and easier to read.

https://codereview.chromium.org/2877483004/diff/60001/appengine/swarming/swar...
appengine/swarming/swarming_bot/bot_code/task_runner_test.py:634:
self.assertEqual(f.read(), 'updated_cache')
self.assertEqual('updated_cache', f.read())

[nodir, 2017-05-11 20:17:14]

The CQ bit was checked by nodir@chromium.org

[nodir, 2017-05-11 20:17:14]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2877483004/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2017-05-11 20:17:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:21:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494533834209140,
"parent_rev": "b1e8e302cf143a45039f9115a202ea356dcbfa3e", "commit_rev":
"b551d1cc05919318aa1d643cfa174a2e2c451ae8"}

[commit-bot: I haz the power, 2017-05-11 20:21:56]

Description was changed from

==========
Reland "named caches: move instead of symlinking"

This relands d1ab255eac4e9ef88d437d476a586d22cda15952
with fixed tests.

BUG=715326
==========

to

==========
Reland "named caches: move instead of symlinking"

This relands d1ab255eac4e9ef88d437d476a586d22cda15952
with fixed tests.

BUG=715326

Review-Url: https://codereview.chromium.org/2877483004
Committed:
https://github.com/luci/luci-py/commit/b551d1cc05919318aa1d643cfa174a2e2c451ae8
==========

[commit-bot: I haz the power, 2017-05-11 20:21:58]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/b551d1cc05919318aa1d643cfa174a2e2c451ae8