Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2877463002:
Move ComputeTextRects and ComputeTextQuads to VisibleUnits. (Closed)
DescriptionMove ComputeTextRects and ComputeTextQuads to VisibleUnits.
This CL moves the functions ComputeTextRects, ComputeTextQuads and
ComputeTextBounds<T> to VisibleUnits.cpp
This is done to avoid duplicate functions in Range and EphemeralRange Class.
BUG=691198
Review-Url: https://codereview.chromium.org/2877463002
Cr-Commit-Position: refs/heads/master@{#471685}
Committed: https://chromium.googlesource.com/chromium/src/+/6b5640c1733e8c715cd6939876663dbb6c44972c
Patch Set 1 #
Total comments: 2
Patch Set 2 : updated PS #
Total comments: 1
Messages
Total messages: 34 (19 generated)
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ==========
tanvir.rizvi@samsung.com changed reviewers: + shanmuga.m@samsung.com, srirama.m@samsung.com
PTAL!!! Thanks
Make sure the description fits within 80characters on each line. https://codereview.chromium.org/2877463002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/2877463002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/VisibleUnits.cpp:4106: LayoutObject* const layoutObject = node.GetLayoutObject(); s/layoutObject/layout_object
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ==========
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ==========
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ==========
https://codereview.chromium.org/2877463002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/2877463002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/VisibleUnits.cpp:4106: LayoutObject* const layoutObject = node.GetLayoutObject(); On 2017/05/11 04:41:41, Srirama wrote: > s/layoutObject/layout_object Done.
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 is in continuation of making textQuads and textRects independent of Range. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 in continuation of making textQuads and textRects independent of Range. Previous CL#3 is https://codereview.chromium.org/2854043002/ This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ==========
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4 in continuation of making textQuads and textRects independent of Range. Previous CL#3 is https://codereview.chromium.org/2854043002/ This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4, in continuation of making textQuads and textRects independent of Range. Previous CL#3 is https://codereview.chromium.org/2854043002/ This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ==========
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This is CL#4, in continuation of making textQuads and textRects independent of Range. Previous CL#3 is https://codereview.chromium.org/2854043002/ This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp This is done to make these functions common for EphemeralRange as well as Range Class. BUG=691198 ==========
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp This is done to make these functions common for EphemeralRange as well as Range Class. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp This is done to avoid duplicate functions in Range and EphemeralRange Class. BUG=691198 ==========
tanvir.rizvi@samsung.com changed reviewers: + tkent@chromium.org, xiaochengh@chromium.org, yosin@chromium.org
PTAL!! Thanks
lgtm https://codereview.chromium.org/2877463002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/Range.cpp (left): https://codereview.chromium.org/2877463002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/Range.cpp:1468: LayoutObject* const layoutObject = node.GetLayoutObject(); Good catch! Thanks!
lgtm We're getting close!
lgtm
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tanvir.rizvi@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494825462869750,
"parent_rev": "a7ab8a110bd6b5339c03a34a5a6bb9a419a49e60", "commit_rev":
"6b5640c1733e8c715cd6939876663dbb6c44972c"}
Message was sent while issue was closed.
Description was changed from ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp This is done to avoid duplicate functions in Range and EphemeralRange Class. BUG=691198 ========== to ========== Move ComputeTextRects and ComputeTextQuads to VisibleUnits. This CL moves the functions ComputeTextRects, ComputeTextQuads and ComputeTextBounds<T> to VisibleUnits.cpp This is done to avoid duplicate functions in Range and EphemeralRange Class. BUG=691198 Review-Url: https://codereview.chromium.org/2877463002 Cr-Commit-Position: refs/heads/master@{#471685} Committed: https://chromium.googlesource.com/chromium/src/+/6b5640c1733e8c715cd693987666... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6b5640c1733e8c715cd693987666... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
