Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 2877413003: [DevTools] Warn that the error is expected (Closed)

Created:
3 years, 7 months ago by eostroukhov
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Warn that the error is expected BUG=721714 Review-Url: https://codereview.chromium.org/2877413003 Cr-Commit-Position: refs/heads/master@{#473003} Committed: https://chromium.googlesource.com/chromium/src/+/e2e76188f78927872885f6fa8c62b76c2095ccdb

Patch Set 1 #

Patch Set 2 : [DevTools] Do not log error during the test run #

Patch Set 3 : [DevTools] Warn that the error is expected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/devtools/devtools_http_handler_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
eostroukhov
3 years, 7 months ago (2017-05-18 22:32:51 UTC) #11
dgozman
lgtm
3 years, 7 months ago (2017-05-18 22:34:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877413003/40001
3 years, 7 months ago (2017-05-18 22:45:18 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:00:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e2e76188f78927872885f6fa8c62...

Powered by Google App Engine
This is Rietveld 408576698