Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2877383003: [translate] Declare additional timers in histograms.xml. (Closed)

Created:
3 years, 7 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
hamelphi, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[translate] Declare additional timers in histograms.xml. This CL declares TranslateRanker.Timer.ReadModel and TranslateRanker.Timer.WriteModel, which capture the time taken to read a model from local storage and commit a model to local storage, respectively. This will allow the UMA dashboard to visualize these metrics. This CL also updates the descriptive text for the other translate ranker model loader timer metrics, to be more explicit about which class generates the metric. BUG=646711 Review-Url: https://codereview.chromium.org/2877383003 Cr-Commit-Position: refs/heads/master@{#472804} Committed: https://chromium.googlesource.com/chromium/src/+/d9203d77503397b78d699d5b8d0686f7d74f8416

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Roger McFarlane (Chromium)
PTAL.
3 years, 7 months ago (2017-05-15 20:07:48 UTC) #3
hamelphi
lgtm
3 years, 7 months ago (2017-05-15 20:54:13 UTC) #4
Roger McFarlane (Chromium)
jwd@: ping?
3 years, 7 months ago (2017-05-16 18:08:39 UTC) #5
jwd
lgtm
3 years, 7 months ago (2017-05-16 22:26:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877383003/20001
3 years, 7 months ago (2017-05-17 18:17:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447430)
3 years, 7 months ago (2017-05-18 02:36:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877383003/20001
3 years, 7 months ago (2017-05-18 13:53:33 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 14:54:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9203d77503397b78d699d5b8d06...

Powered by Google App Engine
This is Rietveld 408576698