Change keyboard initialization animation from 350 ms to 100 ms

Change keyboard initialization animation from 350 ms to 100 ms

BUG=721197
Review-Url: https://codereview.chromium.org/2877373002
Cr-Commit-Position: refs/heads/master@{#471994}
Committed: https://chromium.googlesource.com/chromium/src/+/6eecabd7b0f4d82b3d5a452716c3f02d546d4c96

[Blake, 2017-05-15 07:27:14]

Description was changed from

==========
Change keyboard initialization animation from 350 ms to 100 ms

BUG=721197
==========

to

==========
Change keyboard initialization animation from 350 ms to 100 ms

BUG=721197
==========

[Blake, 2017-05-15 07:27:14]

blakeo@google.com changed reviewers:
+ oka@chromium.org, yhanada@chromium.org

[Blake, 2017-05-15 07:27:36]

blakeo@google.com changed reviewers:
+ blakeo@google.com

[yhanada, 2017-05-15 07:37:53]

https://codereview.chromium.org/2877373002/diff/1/ui/keyboard/keyboard_contro...
File ui/keyboard/keyboard_controller.cc (left):

https://codereview.chromium.org/2877373002/diff/1/ui/keyboard/keyboard_contro...
ui/keyboard/keyboard_controller.cc:50: const int kHideAnimationDurationMs = 100;
As we are going to consolidate the durations of show/hide animation, could you
merge these two variables?

[Blake, 2017-05-15 08:01:44]

On 2017/05/15 07:37:53, yhanada wrote:
>
https://codereview.chromium.org/2877373002/diff/1/ui/keyboard/keyboard_contro...
> File ui/keyboard/keyboard_controller.cc (left):
> 
>
https://codereview.chromium.org/2877373002/diff/1/ui/keyboard/keyboard_contro...
> ui/keyboard/keyboard_controller.cc:50: const int kHideAnimationDurationMs =
100;
> As we are going to consolidate the durations of show/hide animation, could you
> merge these two variables?

Done

[yhanada, 2017-05-15 08:08:11]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 08:08:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-05-15 08:09:52]

lgtm

[Blake, 2017-05-15 08:19:11]

blakeo@google.com changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-05-15 14:48:50]

lgtm

[Blake, 2017-05-16 00:18:44]

The CQ bit was checked by blakeo@google.com

[Blake, 2017-05-16 00:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yhanada@chromium.org
Link to the patchset: https://codereview.chromium.org/2877373002/#ps40001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into animation-change")

[commit-bot: I haz the power, 2017-05-16 00:19:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:58:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494893924877610,
"parent_rev": "42ebc4fd9b073bbcb4a2845aa5862c8fcab2a8a0", "commit_rev":
"6eecabd7b0f4d82b3d5a452716c3f02d546d4c96"}

[commit-bot: I haz the power, 2017-05-16 02:58:15]

Description was changed from

==========
Change keyboard initialization animation from 350 ms to 100 ms

BUG=721197
==========

to

==========
Change keyboard initialization animation from 350 ms to 100 ms

BUG=721197

Review-Url: https://codereview.chromium.org/2877373002
Cr-Commit-Position: refs/heads/master@{#471994}
Committed:
https://chromium.googlesource.com/chromium/src/+/6eecabd7b0f4d82b3d5a452716c3...
==========

[commit-bot: I haz the power, 2017-05-16 02:58:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6eecabd7b0f4d82b3d5a452716c3...