Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2877343002: chromeos: Remove kTestType conditional from ChromeNetworkDelegate (Closed)

Created:
3 years, 7 months ago by satorux1
Modified:
3 years, 7 months ago
Reviewers:
Daniel Erat, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove kTestType conditional from ChromeNetworkDelegate The conditional appears to be no longer necessary in Chrome's tests. Per "repo grep -- --test-type" in chromeos tree, the flag appears not to be passed to chrome in auto tests. BUG=677933 TEST=all linux_chromium_chromeos bots passed Review-Url: https://codereview.chromium.org/2877343002 Cr-Commit-Position: refs/heads/master@{#472352} Committed: https://chromium.googlesource.com/chromium/src/+/4e5aa748d7b05a4057b1960585c3a5b5bc52561a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
satorux1
PTAL
3 years, 7 months ago (2017-05-15 04:17:46 UTC) #8
Daniel Erat
lgtm
3 years, 7 months ago (2017-05-15 05:41:18 UTC) #9
mmenke
On 2017/05/15 05:41:18, Daniel Erat wrote: > lgtm LGTM
3 years, 7 months ago (2017-05-15 12:35:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877343002/1
3 years, 7 months ago (2017-05-17 01:07:25 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 06:30:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e5aa748d7b05a4057b1960585c3...

Powered by Google App Engine
This is Rietveld 408576698