Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2877333002: Make EWordBreak an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EWordBreak an enum class. This patch makes EWordBreak an enum class for better type safety. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2877333002 Cr-Commit-Position: refs/heads/master@{#473133} Committed: https://chromium.googlesource.com/chromium/src/+/7446a544808a998f3698178f1cf309f627592c70

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (22 generated)
shend
Hi Alan PTAL
3 years, 7 months ago (2017-05-14 23:05:50 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-15 04:23:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877333002/40001
3 years, 7 months ago (2017-05-19 08:58:01 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 09:03:34 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7446a544808a998f3698178f1cf3...

Powered by Google App Engine
This is Rietveld 408576698