Add WebContentObserver::OnWebContentsLostFocus()

Add WebContentObserver::OnWebContentsLostFocus()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsLostFocus() callback in
WebContentObserver to export the bluring action.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4bs/edit#heading=h.cgwemqs2j4ta

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lfbG7eunCAAJ

BUG=680809
Review-Url: https://codereview.chromium.org/2877323002
Cr-Commit-Position: refs/heads/master@{#472319}
Committed: https://chromium.googlesource.com/chromium/src/+/3bee08e25f92a3ecaeac0be34dd23fed3596e128

[Hzj_jie, 2017-05-14 21:19:07]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[Hzj_jie, 2017-05-14 21:19:11]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-14 21:19:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-14 22:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-14 22:52:44]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-05-15 22:32:58]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 22:34:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-05-15 22:41:25]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 22:41:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-05-15 22:42:27]

Patchset #2 (id:40001) has been deleted

[Hzj_jie, 2017-05-15 22:42:31]

Patchset #1 (id:20001) has been deleted

[Hzj_jie, 2017-05-15 22:59:47]

Description was changed from

==========
Add WebContentObserver::OnWebContentsBlured()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsBlured() callback in
WebContentObserver to export the blur behavior.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

to

==========
Add WebContentObserver::OnWebContentsBlured()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsBlured() callback in
WebContentObserver to export the blur behavior.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

[Hzj_jie, 2017-05-15 22:59:47]

zijiehe@chromium.org changed reviewers:
+ avi@chromium.org

[Hzj_jie, 2017-05-15 23:06:08]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[Hzj_jie, 2017-05-15 23:06:16]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-05-15 23:06:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[commit-bot: I haz the power, 2017-05-15 23:07:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 00:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:10:21]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Hzj_jie, 2017-05-16 00:18:23]

Description was changed from

==========
Add WebContentObserver::OnWebContentsBlured()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsBlured() callback in
WebContentObserver to export the blur behavior.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

to

==========
Add WebContentObserver::OnWebContentsBlured()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsBlured() callback in
WebContentObserver to export the bluring action.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

[Avi (use Gerrit), 2017-05-16 15:16:20]

"blured" is misspelled; it would be "blurred".

But I think that using "blurred" as the opposite of "focused" is a mistake.
While there are existing antonyms in the observer interface (start/stop,
shown/hidden), it's not obvious that "blurred" is used as the antonym of
"focused". First, it might imply some kind of visual "blurring" effect, not the
loss of focus. And second, "focus" itself has two meanings, one of which (the
photographic meaning) has "blur" as the antonym, but that's not the meaning
we're using here.

Please use "lost focus" as the antonym name for gained focus.

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_view_host_delegate_view.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_view_host_delegate_view.h:65: virtual void
Blured() {}
LostFocus()

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_view_host_impl.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_view_host_impl.h:217: void
RenderWidgetBlured() override;
RenderWidgetLostFocus()

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_owner_delegate.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_owner_delegate.h:45: virtual
void RenderWidgetBlured() = 0;
etc

https://codereview.chromium.org/2877323002/diff/80001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:220: void
NotifyWebContentsBlured();
etc

[Hzj_jie, 2017-05-16 18:07:47]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 18:08:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-05-16 19:39:27]

Thank you Avi for the reviewing and feedbacks.

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_view_host_delegate_view.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_view_host_delegate_view.h:65: virtual void
Blured() {}
On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> LostFocus()

Done.

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_view_host_impl.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_view_host_impl.h:217: void
RenderWidgetBlured() override;
On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> RenderWidgetLostFocus()

Done.

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_owner_delegate.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_owner_delegate.h:45: virtual
void RenderWidgetBlured() = 0;
On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> etc

Done.

https://codereview.chromium.org/2877323002/diff/80001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/2877323002/diff/80001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.h:220: void
NotifyWebContentsBlured();
On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> etc

Done.

[Avi (use Gerrit), 2017-05-16 20:11:10]

On 2017/05/16 19:39:27, Hzj_jie wrote:
> Thank you Avi for the reviewing and feedbacks.
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
> File content/browser/renderer_host/render_view_host_delegate_view.h (right):
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
> content/browser/renderer_host/render_view_host_delegate_view.h:65: virtual
void
> Blured() {}
> On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> > LostFocus()
> 
> Done.
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
> File content/browser/renderer_host/render_view_host_impl.h (right):
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
> content/browser/renderer_host/render_view_host_impl.h:217: void
> RenderWidgetBlured() override;
> On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> > RenderWidgetLostFocus()
> 
> Done.
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
> File content/browser/renderer_host/render_widget_host_owner_delegate.h
(right):
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/rendere...
> content/browser/renderer_host/render_widget_host_owner_delegate.h:45: virtual
> void RenderWidgetBlured() = 0;
> On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> > etc
> 
> Done.
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/web_con...
> File content/browser/web_contents/web_contents_impl.h (right):
> 
>
https://codereview.chromium.org/2877323002/diff/80001/content/browser/web_con...
> content/browser/web_contents/web_contents_impl.h:220: void
> NotifyWebContentsBlured();
> On 2017/05/16 15:16:20, Avi (ping after 24h) wrote:
> > etc
> 
> Done.

Change the description too, if you would.

[Avi (use Gerrit), 2017-05-16 20:13:37]

Almost there.

https://codereview.chromium.org/2877323002/diff/100001/content/public/browser...
File content/public/browser/web_contents_observer.cc (right):

https://codereview.chromium.org/2877323002/diff/100001/content/public/browser...
content/public/browser/web_contents_observer.cc:7: #include
"base/threading/platform_thread.h"
Is this include necessary?

[Hzj_jie, 2017-05-16 20:38:34]

Description was changed from

==========
Add WebContentObserver::OnWebContentsBlured()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsBlured() callback in
WebContentObserver to export the bluring action.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

to

==========
Add WebContentObserver::OnWebContentsLostFocus()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsLostFocus() callback in
WebContentObserver to export the bluring action.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

[Hzj_jie, 2017-05-16 20:42:34]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[Hzj_jie, 2017-05-16 20:43:24]

https://codereview.chromium.org/2877323002/diff/100001/content/public/browser...
File content/public/browser/web_contents_observer.cc (right):

https://codereview.chromium.org/2877323002/diff/100001/content/public/browser...
content/public/browser/web_contents_observer.cc:7: #include
"base/threading/platform_thread.h"
On 2017/05/16 20:13:37, Avi (ping after 24h) wrote:
> Is this include necessary?

No: the change to this file is unexpected.
Done.

[commit-bot: I haz the power, 2017-05-16 20:44:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-05-16 21:01:08]

lgtm

[commit-bot: I haz the power, 2017-05-17 03:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:37:06]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-05-17 04:06:26]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:07:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:14:50]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494993986534240,
"parent_rev": "29c52e534042bff7e45c4a2784d7f4922885b12a", "commit_rev":
"3bee08e25f92a3ecaeac0be34dd23fed3596e128"}

[commit-bot: I haz the power, 2017-05-17 04:15:00]

Description was changed from

==========
Add WebContentObserver::OnWebContentsLostFocus()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsLostFocus() callback in
WebContentObserver to export the bluring action.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809
==========

to

==========
Add WebContentObserver::OnWebContentsLostFocus()

In Keyboard Lock feature, we need to disable low level keyboard lock once the
page lost focus. So this change adds a OnWebContentsLostFocus() callback in
WebContentObserver to export the bluring action.

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

BUG=680809

Review-Url: https://codereview.chromium.org/2877323002
Cr-Commit-Position: refs/heads/master@{#472319}
Committed:
https://chromium.googlesource.com/chromium/src/+/3bee08e25f92a3ecaeac0be34dd2...
==========

[commit-bot: I haz the power, 2017-05-17 04:15:01]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/3bee08e25f92a3ecaeac0be34dd2...