Fixed IAccessible::accNavigate for NAVDIR_NEXT and NAVDIR_PREVIOUS when start object was a simple c…

Fixed IAccessible::accNavigate for NAVDIR_NEXT and NAVDIR_PREVIOUS when start object was a simple child and added extensive tests.

BUG=722148
R=dmazzoni@chromium.org, dougt@chromium.org
TESTED=unit tests, NVDA's navigator object cursor

Review-Url: https://codereview.chromium.org/2877313003
Cr-Commit-Position: refs/heads/master@{#472152}
Committed: https://chromium.googlesource.com/chromium/src/+/2fa0d466bdbd2b52ba16ad9435a2f93d7f4084a5

[dmazzoni, 2017-05-15 20:46:45]

lgtm with one confusing comment

https://codereview.chromium.org/2877313003/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_com_win.cc (right):

https://codereview.chromium.org/2877313003/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_com_win.cc:502: // Forward
all logical directions (e.g. NAVDIR_NEXT) to the platform node
The comment says NAVDIR_NEXT but the code below it
only includes UP, DOWN, LEFT and RIGHT.

[chromium-reviews, 2017-05-15 21:04:18]

https://codereview.chromium.org/2877313003/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility_com_win.cc:502: //
> Forward all logical directions (e.g. NAVDIR_NEXT) to the platform node
> The comment says NAVDIR_NEXT but the code below it
> only includes UP, DOWN, LEFT and RIGHT.

Yes, because the "if" checks for the absence of up/down/left/right, not 
for their presence.
I can modify the comment to say
Forward all non-spatial directions to the AXPlatformNode?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2017-05-16 01:12:19]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-05-16 01:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2877313003/#ps20001
(title: "Fixed comment.")

[commit-bot: I haz the power, 2017-05-16 01:13:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:10:16]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-05-16 17:40:39]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-05-16 17:41:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 17:52:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494956439774880,
"parent_rev": "ac968918d5b2b6baf9fe987cb0094aa9a73177c0", "commit_rev":
"2fa0d466bdbd2b52ba16ad9435a2f93d7f4084a5"}

[commit-bot: I haz the power, 2017-05-16 17:52:50]

Description was changed from

==========
Fixed IAccessible::accNavigate for NAVDIR_NEXT and NAVDIR_PREVIOUS when start
object was a simple child and added extensive tests.

BUG=722148
R=dmazzoni@chromium.org, dougt@chromium.org
TESTED=unit tests, NVDA's navigator object cursor
==========

to

==========
Fixed IAccessible::accNavigate for NAVDIR_NEXT and NAVDIR_PREVIOUS when start
object was a simple child and added extensive tests.

BUG=722148
R=dmazzoni@chromium.org, dougt@chromium.org
TESTED=unit tests, NVDA's navigator object cursor

Review-Url: https://codereview.chromium.org/2877313003
Cr-Commit-Position: refs/heads/master@{#472152}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fa0d466bdbd2b52ba16ad9435a2...
==========

[commit-bot: I haz the power, 2017-05-16 17:52:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fa0d466bdbd2b52ba16ad9435a2...