Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2877233002: Remove the i from visib[i]le. (Closed)

Created:
3 years, 7 months ago by Elliot Glaysher
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, Ian Vollick, tfarina, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the i from visib[i]le. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2877233002 Cr-Commit-Position: refs/heads/master@{#471926} Committed: https://chromium.googlesource.com/chromium/src/+/4ad81c082997550261445c5fc7c88b9a1a64b4f8

Patch Set 1 #

Patch Set 2 : merge with tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/wm_snap_to_pixel_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/wm_snap_to_pixel_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/cursor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_manager_display_root.h View 1 chunk +4 lines, -4 lines 0 comments Download
M services/ui/ws/window_manager_display_root.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_manager_state.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Elliot Glaysher
Just a spelling fix patch.
3 years, 7 months ago (2017-05-12 23:03:06 UTC) #5
sky
LGTM
3 years, 7 months ago (2017-05-14 16:14:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877233002/20001
3 years, 7 months ago (2017-05-15 20:46:19 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 22:30:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ad81c082997550261445c5fc7c8...

Powered by Google App Engine
This is Rietveld 408576698