Don't allow RenderFrames to be created during WebContents destruction.

Don't allow RenderFrames to be created during WebContents destruction.

Some crashes indicate that a WebContentsObserver might be recreating
a RenderFrame after we've called SetRenderFrameCreated(false) in the
WebContentsImpl destructor (e.g., c7fd413350000000).  This isn't safe,
so try to catch any observers that do this.

BUG=717650
TEST=Catch the crash earlier.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2877203002
Cr-Commit-Position: refs/heads/master@{#471493}
Committed: https://chromium.googlesource.com/chromium/src/+/00627245b117b8e2d83a5272fc26222765882323

[Charlie Reis, 2017-05-12 20:42:25]

Description was changed from

==========
Don't allow RenderFrames to be created during WebContents destruction.

Some crashes indicate that a WebContentsObserver might be recreating
a RenderFrame after we've called SetRenderFrameCreated(false) in the
WebContentsImpl destructor (e.g., c7fd413350000000).  This isn't safe,
so try to catch any observers that do this.

BUG=717650
TEST=Catch the crash earlier.
==========

to

==========
Don't allow RenderFrames to be created during WebContents destruction.

Some crashes indicate that a WebContentsObserver might be recreating
a RenderFrame after we've called SetRenderFrameCreated(false) in the
WebContentsImpl destructor (e.g., c7fd413350000000).  This isn't safe,
so try to catch any observers that do this.

BUG=717650
TEST=Catch the crash earlier.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2017-05-12 20:57:48]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 20:58:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-05-12 22:13:13]

creis@chromium.org changed reviewers:
+ nick@chromium.org

[Charlie Reis, 2017-05-12 22:13:14]

Just tested manually that a rogue WebContentsObserver that tries to navigate
during WebContentsDestroyed will trigger this check, while the bug is on the
stack.  Tests aren't catching anything, but maybe we'll catch it in the wild.

[ncarter (slow), 2017-05-12 22:18:32]

I like this. Hopefully it will find bugs.

[ncarter (slow), 2017-05-12 22:24:04]

lgtm

On Fri, May 12, 2017 at 3:18 PM, <nick@chromium.org> wrote:

> I like this. Hopefully it will find bugs.
>
> https://codereview.chromium.org/2877203002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Charlie Reis, 2017-05-12 22:24:54]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2017-05-12 22:24:58]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:25:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 22:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:25:20]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[ncarter (slow), 2017-05-12 22:26:26]

git cl lgtm --rebase-all --force --hard --with-branch-heads -- */*

[Charlie Reis, 2017-05-12 22:28:38]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:29:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:43:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494628118439890,
"parent_rev": "d3fb77dd1755e394ef80fabd0f06a599d61a764a", "commit_rev":
"00627245b117b8e2d83a5272fc26222765882323"}

[commit-bot: I haz the power, 2017-05-12 23:43:46]

Description was changed from

==========
Don't allow RenderFrames to be created during WebContents destruction.

Some crashes indicate that a WebContentsObserver might be recreating
a RenderFrame after we've called SetRenderFrameCreated(false) in the
WebContentsImpl destructor (e.g., c7fd413350000000).  This isn't safe,
so try to catch any observers that do this.

BUG=717650
TEST=Catch the crash earlier.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Don't allow RenderFrames to be created during WebContents destruction.

Some crashes indicate that a WebContentsObserver might be recreating
a RenderFrame after we've called SetRenderFrameCreated(false) in the
WebContentsImpl destructor (e.g., c7fd413350000000).  This isn't safe,
so try to catch any observers that do this.

BUG=717650
TEST=Catch the crash earlier.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2877203002
Cr-Commit-Position: refs/heads/master@{#471493}
Committed:
https://chromium.googlesource.com/chromium/src/+/00627245b117b8e2d83a5272fc26...
==========

[commit-bot: I haz the power, 2017-05-12 23:43:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00627245b117b8e2d83a5272fc26...