|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by Xiaocheng Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune ComputeVisibleSelectionDeprecated from FrameSelection::ShouldPaintCaret
This patch prunes a call site of the deprecated function, which is safe because
layout is already clean (DCHECK-ed) at the call site.
BUG=698633
TEST=n/a; no behavioral changes.
Review-Url: https://codereview.chromium.org/2877193002
Cr-Commit-Position: refs/heads/master@{#471659}
Committed: https://chromium.googlesource.com/chromium/src/+/f4728d7d5a0884f5c40614fd9d29bf50c08a8a32
Patch Set 1 #
Messages
Total messages: 17 (13 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Prune ComputeVisibleSelectionDeprecated from FrameSelection::ShouldPaintCaret BUG= ========== to ========== Prune ComputeVisibleSelectionDeprecated from FrameSelection::ShouldPaintCaret This patch prunes a call site of the deprecated function, which is safe because layout is already clean (DCHECK-ed) at the call site. BUG=698633 TEST=n/a; no behavioral changes. ==========
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494814416385830, "parent_rev":
"77f5935267dfb3f96b9194b18e9b824ba086ea74", "commit_rev":
"f4728d7d5a0884f5c40614fd9d29bf50c08a8a32"}
Message was sent while issue was closed.
Description was changed from ========== Prune ComputeVisibleSelectionDeprecated from FrameSelection::ShouldPaintCaret This patch prunes a call site of the deprecated function, which is safe because layout is already clean (DCHECK-ed) at the call site. BUG=698633 TEST=n/a; no behavioral changes. ========== to ========== Prune ComputeVisibleSelectionDeprecated from FrameSelection::ShouldPaintCaret This patch prunes a call site of the deprecated function, which is safe because layout is already clean (DCHECK-ed) at the call site. BUG=698633 TEST=n/a; no behavioral changes. Review-Url: https://codereview.chromium.org/2877193002 Cr-Commit-Position: refs/heads/master@{#471659} Committed: https://chromium.googlesource.com/chromium/src/+/f4728d7d5a0884f5c40614fd9d29... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f4728d7d5a0884f5c40614fd9d29... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
