Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2805)

Unified Diff: chrome/browser/extensions/api/settings_private/prefs_util.cc

Issue 2877173002: Add scale to settings-slider (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/settings_private/prefs_util.cc
diff --git a/chrome/browser/extensions/api/settings_private/prefs_util.cc b/chrome/browser/extensions/api/settings_private/prefs_util.cc
index 6a274bf1c18c4c920babce47d08b7c01966813ff..318550e797ea3c77acde5015d8d76913ee994b39 100644
--- a/chrome/browser/extensions/api/settings_private/prefs_util.cc
+++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc
@@ -543,8 +543,6 @@ PrefsUtil::SetPrefResult PrefsUtil::SetPref(const std::string& pref_name,
if (!pref)
return PREF_NOT_FOUND;
- DCHECK_EQ(pref->GetType(), value->GetType());
stevenjb 2017/05/12 18:49:32 I ran into this when testing. This DCHECK is bogus
afakhry 2017/05/12 19:12:13 Yes, that's the DCHECK that was causing me grief.
-
switch (pref->GetType()) {
case base::Value::Type::BOOLEAN:
case base::Value::Type::DOUBLE:

Powered by Google App Engine
This is Rietveld 408576698