Add scale to settings-slider

chrome/browser/extensions/api/settings_private/prefs_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/settings_private/prefs_util.h"
 
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/browser/extensions/settings_api_helpers.h"
@@ skipping 525 matching lines @@
 
   PrefService* pref_service = FindServiceForPref(pref_name);
 
   if (!IsPrefUserModifiable(pref_name))
     return PREF_NOT_MODIFIABLE;
 
   const PrefService::Preference* pref = pref_service->FindPreference(pref_name);
   if (!pref)
     return PREF_NOT_FOUND;
 
-  DCHECK_EQ(pref->GetType(), value->GetType());

[stevenjb, 2017/05/12 18:49:32]

I ran into this when testing. This DCHECK is bogus since we call
value->GetAsDouble() for pref->GetType() == base::Value::Type::INTEGER on line
558.

[afakhry, 2017/05/12 19:12:13]

Yes, that's the DCHECK that was causing me grief.

-
   switch (pref->GetType()) {
     case base::Value::Type::BOOLEAN:
     case base::Value::Type::DOUBLE:
     case base::Value::Type::LIST:
     case base::Value::Type::DICTIONARY:
       pref_service->Set(pref_name, *value);
       break;
     case base::Value::Type::INTEGER: {
       // In JS all numbers are doubles.
       double double_value;
@@ skipping 213 matching lines @@
       ExtensionPrefValueMapFactory::GetForBrowserContext(profile_)
           ->GetExtensionControllingPref(pref_object.key);
   if (extension_id.empty())
     return nullptr;
 
   return ExtensionRegistry::Get(profile_)->GetExtensionById(
       extension_id, ExtensionRegistry::ENABLED);
 }
 
 }  // namespace extensions